DB compatibility and notification bug fix #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes notification bugs where notifications weren't being regenerated when task due dates were updated, and addresses database compatibility issues with JSON serialization in GORM by removing the explicit type:json type specification.
- Added notification generation to
UpdateDueDateand CalDAV PUT operations where date updates occur - Removed
type:jsonfrom GORM serializer tags for better cross-database compatibility - Integrated notification repository into CalDAV API handler
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apiserver/internal/services/tasks/task.go | Added notification generation goroutine to UpdateDueDate function to ensure notifications are regenerated when due dates change |
| apiserver/internal/models/user.go | Removed type:json specification from Scopes field GORM tag to improve database compatibility while maintaining JSON serialization |
| apiserver/internal/models/recurrence.go | Removed type:json specification from Days and Months GORM tags to improve database compatibility while maintaining JSON serialization |
| apiserver/internal/apis/caldav.go | Added notification repository dependency and regeneration logic to CalDAV PUT handler for task updates via CalDAV protocol |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notifications weren't getting updated in a couple code paths where date gets updated on its own.
Json dt doesn't seem to perform well for some DBSM, using the serializer without the underlying dt to try