Fix multiple checkbox values lost in GET form submissions #2181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When submitting forms with multiple checkboxes sharing the same name via GET, only the last value was preserved in query parameters instead of all selected values (
?name=value3instead of?name=value1&name=value2&name=value3). This caused server-side parameter parsing failures.Changes
url.searchParams.set()tourl.searchParams.append()to match the correct behavior already present on line 281The issue was an inconsistency in query parameter building - the code that constructs the actual server request correctly used
append(), but the code that updates the browser address bar usedset(), which overwrites duplicate keys.This ensures both the displayed URL and the actual request contain all checkbox values.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.