Skip to content

Conversation

@icyc9
Copy link
Collaborator

@icyc9 icyc9 commented Dec 3, 2018

example is broken and elements aren't instantiating. moved snuggsi import to above the link tags. @snuggs

example is broken and elements aren't instantiating.
Copy link
Collaborator

@brandondees brandondees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. @snuggs was this expected/intended to work the other way for some reason?

@snuggs
Copy link
Member

snuggs commented Dec 3, 2018

Hmmmmm @Robertchristopher it's a bug if we want to make it a feature. :-) (For now) This looks good. But TECHNICALLY a good user experience would be if where <script src=snuggsi...> is inconsequential. (At least I thought it worked that way for custom elements).

I'm taking a look as well but this looks good regardless. Nice catch by the way. I've definitely experienced this before. Now we can actually have a test for it due to work @brandondees and @tmornini and I did with test coverage. #162, #70, #62

@brandondees
Copy link
Collaborator

It would be really nice if we can achieve that but until we can prove that's a safe assumption to rely on, I'd rather say don't assume it can do that and always load the dependency first. @snuggs the CI hook seems to not be responding but it passed already. Merge away.

@brandondees brandondees merged commit 7923169 into master Dec 10, 2018
@snuggs snuggs deleted the fix-example branch December 11, 2018 01:33
@snuggs
Copy link
Member

snuggs commented Dec 11, 2018

Well done @brandondees

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants