Add Rails Dev Container Templates and Features to Collection Index #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
left a comment
rafaelfranca
left a comment
There was a problem hiding this comment.
I'd like to get this ready to be merged. I made a few comments.
Comment on lines
+1260
to
+1264
| - name: Rails Dev Container Templates | ||
| maintainer: Rails Contributors | ||
| contact: https://github.com/rails/devcontainer/issues | ||
| repository: https://github.com/rails/devcontainer | ||
| ociReference: ghcr.io/rails/devcontainer/images |
There was a problem hiding this comment.
Suggested change
| - name: Rails Dev Container Templates | |
| maintainer: Rails Contributors | |
| contact: https://github.com/rails/devcontainer/issues | |
| repository: https://github.com/rails/devcontainer | |
| ociReference: ghcr.io/rails/devcontainer/images |
Images aren't templates. We don't have templates yet.
| repository: https://github.com/rails/devcontainer | ||
| ociReference: ghcr.io/rails/devcontainer/images | ||
| - name: Rails Dev Container Features | ||
| maintainer: Rails Contributors |
There was a problem hiding this comment.
Suggested change
| maintainer: Rails Contributors | |
| maintainer: Rails Core Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Related Issues
Description
Adds the dev container images and features created by the Rails community.
Collection checklist
If your PR contributes a new collection, please utilize this checklist: