refactor: replace hardcoded colors with theme variables #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Contributor
Changepacks |
owjs3901
requested changes
Jan 25, 2026
| } | ||
| style={{ | ||
| backgroundColor: 'var(--primary)', | ||
| backgroundColor: 'var(--toggleBg)', |
Contributor
There was a problem hiding this comment.
className={css({bg: "$toggleBg"})} 로 개선이 가능하면 개선을 바랍니다.
Comment on lines
+30
to
+38
| "primary": "#F0F4E1", | ||
| "secondary": "#A1BEBF", | ||
| "link": "#BA99FF", | ||
| "text": "#F0F4E1", | ||
| "background": "#011919", | ||
| "containerBackground": "#022322", | ||
| "border": "#013936", | ||
| "success": "#009F99", | ||
| "warning": "#E9FF66", |
Contributor
There was a problem hiding this comment.
primary color 등 전체적인 톤은 설계가 된 것이라서 변경이 힘들 것 같습니다. (전체적인 톤은 색맹을 고려한 디자인 색입니다.)
Author
There was a problem hiding this comment.
그렇군요! 그럼 색감 조정이 아니라 기존 컬러칩의 사용영역을 조정해놔야겠네요!
| <TestCaseCircle key={text + idx} isSuccess={isSuccess}> | ||
| <Box minW="50vw" w="100%" whiteSpace="pre-wrap"> | ||
| <Text color="#FFF" typography="body"> | ||
| <Text color="$testCaseText" typography="body"> |
| key={index + 'desktop'} | ||
| className={css({ | ||
| bg: isSuccess ? 'unset' : '#D8D8D8', | ||
| bg: isSuccess ? 'unset' : '$testCaseFailedBg', |
Contributor
There was a problem hiding this comment.
Looks good. We should use color tokens instead of constant colors
| justifyContent="center" | ||
| px="20px" | ||
| py="8px" | ||
| selectors={{ |
Contributor
There was a problem hiding this comment.
using _lastChild and _firstChild syntex
| borderLeft: 'solid 1px #2B2B2B', | ||
| borderLeft: 'solid 1px $tableBorder', | ||
| }, | ||
| 'tr[data-responsive="desktop"]:first-of-type &, tr[data-responsive="mobile"]:nth-of-type(2) &': |
Contributor
There was a problem hiding this comment.
지금 보니까 이거 좀 아쉽네요
borderTop: [~, null, "initial", null, ~]
이런식으로 data-responsive를 설정하지 않고도 이를 개선할 수 있었을 텐데.. 여기까지 해보실 수 있을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #139
Dark mode UI Updated
기존 UI의 이슈
수정한 UI 요소