Remove Fabric Dependency #628
Open
+3,613
−317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'functional' target in the Makefile now accepts an optional THREADS parameter. If no THREADS value is supplied, it defaults to 'auto'. This allows users to specify the number of parallel test threads, addressing potential resource issues like SQL Server running out of memory when many tests run concurrently.
…rather than taking all the cores.
…sql version of the adapter as the upstream testing was relied on. Fix snapshot logic not being updated to 1.9 to pass tests. Fix issues with the test failure storage tests related to expected errors due to bad model naming.
for more information, see https://pre-commit.ci
|
@Benjamin-Knight I am just an extremely happy user of this adapter but if there is something I could potentially help with please let me know and I will check with my employer if I can carve out some time to work, do tests, etc on this adapter. |
Contributor
Author
Right now we are kind of on hold until a maintainer appears. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a big one that aims to remove the dependency this adapter has on the dbt-fabric adapter.
As Fabric drifts further from SQL server it will become increasingly difficult to keep Fabric as a base, its also still on version 1.9.
I've also looked at the work @axellpadilla has been doing recently and added in the CI work to support python 3.13 with a view to bumping this adapter up to version 1.11 to match the current DBT core release.
@cody-scott As the most recently active maintainer are you able to help progress this issue or hand additional rights to myself or @axellpadilla to see if we can start closing off some of the issues on this adapter?
In terms of the pull request as its a big one the more eyes on it the better, I've ported over some of the functional tests from Fabric that were not implemented in this adapter to try and keep coverage up and all current functional tests we had are passing. I think we may still want to do a beta release however.