Don't offer completions for numeric text #1470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandwalker
force-pushed
the
RW/do-not-attempt-to-complete-numbers
branch
2 times, most recently
from
2722ada to
83e7dbb
Compare
Identifiers which begin with numbers can still be completed by starting the text with a backquote. That might be a little fragile but works for now.
rolandwalker
force-pushed
the
RW/do-not-attempt-to-complete-numbers
branch
from
83e7dbb to
bf7fb7a
Compare
scottnemes
approved these changes
Jan 23, 2026
Contributor
scottnemes
left a comment
scottnemes
left a comment
There was a problem hiding this comment.
Works as-is.
Either for future or to update this if you want, seems like it would be good to restrict the new number logic to only certain types of completions; i.e. keywords. I would expect you'd still want completions for tables, databases, and columns at least. Should be a limited case as it's not best practice to name stuff with numbers up front anyway, but something to consider. Since it works with the backticks as you mentioned that is doable now anyway.
Contributor
Author
|
Valid points! But I'm not clever enough about the completions to do that yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Identifiers which begin with numbers can still be completed by starting the text with a backquote. That might be a little fragile but works for now. Example:
Example of the undesirable old behavior which is fixed in this PR:
Checklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff format && uv run mypy --install-types .to lint and format the code.