Skip to content

DAOS-18368 rebuild: fix use before check of ec_agg_boundary #17324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
liuxuezhao wants to merge 3 commits into
base: master
Choose a base branch
from
Open

DAOS-18368 rebuild: fix use before check of ec_agg_boundary #17324

liuxuezhao wants to merge 3 commits into from
+170 −47

Conversation

@liuxuezhao
Copy link
Contributor

@liuxuezhao liuxuezhao commented Dec 29, 2025 •
edited
Loading 

1. fix a bug of using ec_agg_boundary before checking its valid
2. add some more logs for rebuild fetch getting zero iod_size,
   to provide some hints for layout information.
3. fix a REINT bug that possibly complete the rebuild ahead before
    reint engines' pull completion.

 Signed-off-by: Xuezhao Liu <xuezhao.liu@hpe.com>

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@liuxuezhao liuxuezhao requested review from a team as code owners December 29, 2025 09:18
@github-actions
Copy link

github-actions bot commented Dec 29, 2025

Ticket title is 'Data corruption observed with master branch under MDonSSD environment.'
Status is 'In Progress'
Labels: 'md_on_ssd,scrubbed_2.8'
https://daosio.atlassian.net/browse/DAOS-18368

@liuxuezhao liuxuezhao mentioned this pull request Dec 29, 2025
Merged
6 tasks
@liuxuezhao liuxuezhao force-pushed the lxz/rb_fix_ec_agg_eph branch 2 times, most recently from 122e9e8 to 10fa58e Compare December 29, 2025 10:39
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 29, 2025

Test stage NLT on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17324/2/display/redirect

NiuYawei
NiuYawei previously approved these changes Dec 30, 2025
View reviewed changes
@liuxuezhao liuxuezhao force-pushed the lxz/rb_fix_ec_agg_eph branch from 10fa58e to 66f44a9 Compare December 31, 2025 06:06
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 31, 2025

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17324/4/testReport/

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 31, 2025

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17324/4/execution/node/1313/log

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 31, 2025

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17324/4/execution/node/1323/log

@liuxuezhao
Copy link
Contributor Author

liuxuezhao commented Jan 4, 2026

just refresh to change a few logs.

@liuxuezhao liuxuezhao requested a review from NiuYawei January 4, 2026 10:47
@liuxuezhao liuxuezhao force-pushed the lxz/rb_fix_ec_agg_eph branch 2 times, most recently from 32db84f to e1c08ea Compare January 4, 2026 11:00
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Jan 4, 2026

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17324/7/testReport/

NiuYawei
NiuYawei previously approved these changes Jan 5, 2026
View reviewed changes
wangshilong
wangshilong previously approved these changes Jan 5, 2026
View reviewed changes
@liuxuezhao
DAOS-18368 rebuild: fix use before check of ec_agg_boundary
99a1722 
1. fix a bug of using ec_agg_boundary before checking its valid
2. add some more logs for rebuild fetch getting zero iod_size,
   to provide some hints for layout information.

 Signed-off-by: Xuezhao Liu <xuezhao.liu@hpe.com>
@liuxuezhao
DAOS-18368 rebuild: a few log change
4405393 
Signed-off-by: Xuezhao Liu <xuezhao.liu@hpe.com>
@liuxuezhao
DAOS-18368 rebuild: fix a REINT bug
c474fe4 
rebuild leader possibly treat reint engine as completion before its
pulling DONE.

Signed-off-by: Xuezhao Liu <xuezhao.liu@hpe.com>
@liuxuezhao liuxuezhao dismissed stale reviews from wangshilong and NiuYawei via c474fe4 January 7, 2026 07:31
@liuxuezhao liuxuezhao force-pushed the lxz/rb_fix_ec_agg_eph branch from e1c08ea to c474fe4 Compare January 7, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnailzenh gnailzenh Awaiting requested review from gnailzenh

@wangshilong wangshilong Awaiting requested review from wangshilong

@NiuYawei NiuYawei Awaiting requested review from NiuYawei

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@liuxuezhao @daosbuild3 @wangshilong @NiuYawei