Handle infinite lastGeneratedColumn #250
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I understand correctly, the source-map library may set lastGeneratedColumn to infinity for the end of a mapping range: https://github.com/mozilla/source-map/blob/v0.7.4/lib/source-map-consumer.js#L405 I believe it makes sense to represent this as the last valid column. See danvk#248
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I understand correctly, the source-map library may set lastGeneratedColumn to infinity for the end of a mapping range:
https://github.com/mozilla/source-map/blob/v0.7.4/lib/source-map-consumer.js#L405
I believe it makes sense to represent this as the last valid column.
Without this patch, we were getting errors similar to the following:
With this patch, I get identical output to what I get from running
source-map-explore --no-border-checks.See #248