-
Notifications
You must be signed in to change notification settings - Fork 6
feat: advanced state mapping support #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: d3cc9f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📦 NPM canary releaseDeployed canary version 0.0.0-canary-7df2db2. |
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
🧪 Storybook is successfully deployed!
|
| export const GlobalStyles = (props: GlobalStylesProps) => { | ||
| const newProps: GlobalStylesElementProps = {}; | ||
| export function GlobalStyles(props: GlobalStylesProps) { | ||
| const { bodyStyles, font, monospaceFont } = props; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GlobalStyles silently ignores fonts, fontDisplay, and publicUrl props
The GlobalStyles component declares fonts, fontDisplay, and publicUrl in its props interface (lines 10-12) but the function only destructures bodyStyles, font, and monospaceFont on line 303. These three props are passed from Root.tsx but are completely ignored. This is a silent regression where existing code using these props (e.g., fontDisplay="auto" in storybook) will have no effect. Either the props need to be implemented or marked as deprecated in the interface.
Describe changes
Checklist
Before taking this PR from the draft, please, make sure you have done the following:
Closes: N/A
Other information
Note
Introduces a more powerful styling system with advanced states, new hooks, and a static build path.
AdvancedStates.stories.tsx,Tasty.docs.mdx,StyleInjector.docs.mdx)useStyles(scoped classes),useGlobalStyles(selector-scoped), anduseRawCSS(raw CSS injection); removecreateGlobalStyleGlobalStylesto hooks, updatesRoot(drops breakpoints logic, tokens applied via globals), exportstokenstasty/static,tasty/zero,tasty/zero/babel,tasty/zero/next; updatespackage.jsonexports and adds Babel depsButton,Item,CopyPasteBlock,Layout, etc.)Written by Cursor Bugbot for commit d3cc9f8. This will update automatically on new commits. Configure here.