NO_MERGE This is an example PR with an upstream commit checker github action #323

bmastbergen · 2025-06-06T18:32:37Z

This is an example PR for testing an upstream commit checker github action. It has three commits that reference upstream commits. One references a bogus upstream commit. One references an upstream commit with a single fix available. And one references an upstream commit with multiple fixes available.

PlaidCat · 2025-06-06T18:56:44Z

.github/workflows/upstream-commit-check.yml

+      - name: Clone Linux Kernel
+        run: |
+          echo "Cloning Linux kernel repository (bare clone, single branch, no blobs) into 'linux' directory..."
+          git clone --bare --filter=blob:none --single-branch https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git linux


Any reason we just can't use the kernel-mainline branch its updated daily

It could. If you look below you'll see that the script doesn't actually checkout the kernel-src-tree repo. It uses the github api to get the commits in the PR. But yea, maybe actually checking out kernel-src-tree with its kernel-mainline branch included makes sense.

Initially the script used the github api to check the upstream kernel commits too, but that was taking forever

bmastbergen · 2025-06-06T19:55:44Z

closing this. its served its purpose

thefossguy-ciq · 2025-06-07T05:29:22Z

This is amazing! This could help us improve the quality of our tree better than RedHat's.

bmastbergen · 2025-06-10T14:37:08Z

Reopening for more testing

jira VULN-XXXX cve CVE-2025-1234 commit 1234567890abcde1234567890abcde1234567890 This isn't a real commit Do i dont have to say anything here

jira VULN-XXXX cve CVE-2025-1234 commit a85fb91 This isn't a real commit Do i dont have to say anything here

commit 0d0f417 That is all

This github actions checks the PR commits for references to upstream linux commits (lines starting with "commit <hash>") and does two things: 1. Checks that this hash exists in the upstream linux kernel history 2. Checks if there are any Fixes: references for the referenced commit in the upstream linux kernel history If either of those are found to be true a comment is added to the PR with the pertinent information. The logic for the check is provided by the check_upstream_commits.py script from kernel-src-tree-tools

github-actions · 2025-08-08T18:12:03Z

🔍 Upstream Linux Kernel Commit Check

❗ PR commit 7ddbec52cba7 (This commit references a bogus upstream hash) references upstream commit
1234567890ab which does not exist in the upstream Linux kernel.
⚠️ PR commit 057a8eaab3b3 (This commit references an upstream hash with a fix available) references upstream commit
a85fb91e3d72 which has been referenced by a Fixes: tag in the upstream
Linux kernel:

    27aabf27fd01 Bluetooth: fix use-after-free in device_for_each_child() (Dmitry Antipov)

⚠️ PR commit f7f3e0868745 (This commit references an upstream hash with multiple fixes) references upstream commit
0d0f4174f6c8 which has been referenced by a Fixes: tag in the upstream
Linux kernel:

    b25b44cd178c selftests: drv-net: tso: fix non-tunneled tso6 test case name (Daniel Zahka)
    2cfbcc5d8af9 selftests: drv-net: tso: fix vxlan tunnel flags to get correct gso_type (Daniel Zahka)
    266b835e5e84 selftests: drv-net: tso: enable test cases based on hw_features (Daniel Zahka)
    d74cd9a02f02 selftests: drv-net: Make command requirements explicit (Gal Pressman)
    e6854be4d80e selftests: drv-net: tso: make bkg() wait for socat to quit (Jakub Kicinski)
    c68804c934e3 selftests: drv-net: tso: fix the GRE device name (Jakub Kicinski)
    7eb6b63aa3c3 selftests: drv-net: add configs for the TSO test (Jakub Kicinski)
    8af7a919c52f netlink: specs: rt-link: decode ip6gre (Jakub Kicinski)

This is an automated message from the kernel commit checker workflow.

bmastbergen · 2025-08-11T17:19:10Z

this has served its purpose......again

Synthetic events currently do not have a function to register perf events. This leads to calling the tracepoint register functions with a NULL function pointer which triggers: ------------[ cut here ]------------ WARNING: kernel/tracepoint.c:175 at tracepoint_add_func+0x357/0x370, CPU#2: perf/2272 Modules linked in: kvm_intel kvm irqbypass CPU: 2 UID: 0 PID: 2272 Comm: perf Not tainted 6.18.0-ftest-11964-ge022764176fc-dirty #323 PREEMPTLAZY Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.17.0-debian-1.17.0-1 04/01/2014 RIP: 0010:tracepoint_add_func+0x357/0x370 Code: 28 9c e8 4c 0b f5 ff eb 0f 4c 89 f7 48 c7 c6 80 4d 28 9c e8 ab 89 f4 ff 31 c0 5b 41 5c 41 5d 41 5e 41 5f 5d c3 cc cc cc cc cc <0f> 0b 49 c7 c6 ea ff ff ff e9 ee fe ff ff 0f 0b e9 f9 fe ff ff 0f RSP: 0018:ffffabc0c44d3c40 EFLAGS: 00010246 RAX: 0000000000000001 RBX: ffff9380aa9e4060 RCX: 0000000000000000 RDX: 000000000000000a RSI: ffffffff9e1d4a98 RDI: ffff937fcf5fd6c8 RBP: 0000000000000001 R08: 0000000000000007 R09: ffff937fcf5fc780 R10: 0000000000000003 R11: ffffffff9c193910 R12: 000000000000000a R13: ffffffff9e1e5888 R14: 0000000000000000 R15: ffffabc0c44d3c78 FS: 00007f6202f5f340(0000) GS:ffff93819f00f000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 000055d3162281a8 CR3: 0000000106a56003 CR4: 0000000000172ef0 Call Trace: <TASK> tracepoint_probe_register+0x5d/0x90 synth_event_reg+0x3c/0x60 perf_trace_event_init+0x204/0x340 perf_trace_init+0x85/0xd0 perf_tp_event_init+0x2e/0x50 perf_try_init_event+0x6f/0x230 ? perf_event_alloc+0x4bb/0xdc0 perf_event_alloc+0x65a/0xdc0 __se_sys_perf_event_open+0x290/0x9f0 do_syscall_64+0x93/0x7b0 ? entry_SYSCALL_64_after_hwframe+0x76/0x7e ? trace_hardirqs_off+0x53/0xc0 entry_SYSCALL_64_after_hwframe+0x76/0x7e Instead, have the code return -ENODEV, which doesn't warn and has perf error out with: # perf record -e synthetic:futex_wait Error: The sys_perf_event_open() syscall returned with 19 (No such device) for event (synthetic:futex_wait). "dmesg | grep -i perf" may provide additional information. Ideally perf should support synthetic events, but for now just fix the warning. The support can come later. Cc: stable@vger.kernel.org Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Cc: Arnaldo Carvalho de Melo <acme@kernel.org> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Link: https://patch.msgid.link/20251216182440.147e4453@gandalf.local.home Fixes: 4b14793 ("tracing: Add support for 'synthetic' events") Reported-by: Ian Rogers <irogers@google.com> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>

commit ef7f38d upstream. Synthetic events currently do not have a function to register perf events. This leads to calling the tracepoint register functions with a NULL function pointer which triggers: ------------[ cut here ]------------ WARNING: kernel/tracepoint.c:175 at tracepoint_add_func+0x357/0x370, CPU#2: perf/2272 Modules linked in: kvm_intel kvm irqbypass CPU: 2 UID: 0 PID: 2272 Comm: perf Not tainted 6.18.0-ftest-11964-ge022764176fc-dirty #323 PREEMPTLAZY Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.17.0-debian-1.17.0-1 04/01/2014 RIP: 0010:tracepoint_add_func+0x357/0x370 Code: 28 9c e8 4c 0b f5 ff eb 0f 4c 89 f7 48 c7 c6 80 4d 28 9c e8 ab 89 f4 ff 31 c0 5b 41 5c 41 5d 41 5e 41 5f 5d c3 cc cc cc cc cc <0f> 0b 49 c7 c6 ea ff ff ff e9 ee fe ff ff 0f 0b e9 f9 fe ff ff 0f RSP: 0018:ffffabc0c44d3c40 EFLAGS: 00010246 RAX: 0000000000000001 RBX: ffff9380aa9e4060 RCX: 0000000000000000 RDX: 000000000000000a RSI: ffffffff9e1d4a98 RDI: ffff937fcf5fd6c8 RBP: 0000000000000001 R08: 0000000000000007 R09: ffff937fcf5fc780 R10: 0000000000000003 R11: ffffffff9c193910 R12: 000000000000000a R13: ffffffff9e1e5888 R14: 0000000000000000 R15: ffffabc0c44d3c78 FS: 00007f6202f5f340(0000) GS:ffff93819f00f000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 000055d3162281a8 CR3: 0000000106a56003 CR4: 0000000000172ef0 Call Trace: <TASK> tracepoint_probe_register+0x5d/0x90 synth_event_reg+0x3c/0x60 perf_trace_event_init+0x204/0x340 perf_trace_init+0x85/0xd0 perf_tp_event_init+0x2e/0x50 perf_try_init_event+0x6f/0x230 ? perf_event_alloc+0x4bb/0xdc0 perf_event_alloc+0x65a/0xdc0 __se_sys_perf_event_open+0x290/0x9f0 do_syscall_64+0x93/0x7b0 ? entry_SYSCALL_64_after_hwframe+0x76/0x7e ? trace_hardirqs_off+0x53/0xc0 entry_SYSCALL_64_after_hwframe+0x76/0x7e Instead, have the code return -ENODEV, which doesn't warn and has perf error out with: # perf record -e synthetic:futex_wait Error: The sys_perf_event_open() syscall returned with 19 (No such device) for event (synthetic:futex_wait). "dmesg | grep -i perf" may provide additional information. Ideally perf should support synthetic events, but for now just fix the warning. The support can come later. Cc: stable@vger.kernel.org Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Cc: Arnaldo Carvalho de Melo <acme@kernel.org> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Link: https://patch.msgid.link/20251216182440.147e4453@gandalf.local.home Fixes: 4b14793 ("tracing: Add support for 'synthetic' events") Reported-by: Ian Rogers <irogers@google.com> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

PlaidCat reviewed Jun 6, 2025

View reviewed changes

bmastbergen closed this Jun 6, 2025

bmastbergen reopened this Jun 10, 2025

bmastbergen force-pushed the NO_MERGE-upstream-commit-checker-example branch 2 times, most recently from 37e3a27 to 4bd3171 Compare June 10, 2025 14:58

ctrliq deleted a comment from github-actions bot Jun 10, 2025

bmastbergen force-pushed the NO_MERGE-upstream-commit-checker-example branch 4 times, most recently from 025c28b to e6ae83a Compare June 10, 2025 17:58

ctrliq deleted a comment from github-actions bot Jun 10, 2025

ctrliq deleted a comment from github-actions bot Jun 11, 2025

bmastbergen force-pushed the NO_MERGE-upstream-commit-checker-example branch 2 times, most recently from 5e214cb to b82196f Compare June 11, 2025 15:08

ctrliq deleted a comment from github-actions bot Jun 11, 2025

bmastbergen mentioned this pull request Jun 11, 2025

Add script to validate upstream references in PR branch commits ctrliq/kernel-src-tree-tools#22

Merged

bmastbergen force-pushed the NO_MERGE-upstream-commit-checker-example branch from b82196f to 97a0c5d Compare June 12, 2025 14:12

ctrliq deleted a comment from github-actions bot Jun 12, 2025

bmastbergen added 4 commits August 8, 2025 09:36

This commit references a bogus upstream hash

7ddbec5

jira VULN-XXXX cve CVE-2025-1234 commit 1234567890abcde1234567890abcde1234567890 This isn't a real commit Do i dont have to say anything here

This commit references an upstream hash with a fix available

057a8ea

jira VULN-XXXX cve CVE-2025-1234 commit a85fb91 This isn't a real commit Do i dont have to say anything here

This commit references an upstream hash with multiple fixes

f7f3e08

commit 0d0f417 That is all

bmastbergen force-pushed the NO_MERGE-upstream-commit-checker-example branch from 97a0c5d to 0ae35ad Compare August 8, 2025 18:02

ctrliq deleted a comment from github-actions bot Aug 8, 2025

bmastbergen mentioned this pull request Aug 8, 2025

[cbr79] github actions: Add upstream commit checker #474

Merged

bmastbergen closed this Aug 11, 2025

bmastbergen deleted the NO_MERGE-upstream-commit-checker-example branch August 15, 2025 19:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

NO_MERGE This is an example PR with an upstream commit checker github action #323

NO_MERGE This is an example PR with an upstream commit checker github action #323

Uh oh!

bmastbergen commented Jun 6, 2025 •

edited

Loading

Uh oh!

PlaidCat Jun 6, 2025

Uh oh!

bmastbergen Jun 6, 2025 •

edited

Loading

Uh oh!

bmastbergen Jun 6, 2025

Uh oh!

bmastbergen commented Jun 6, 2025

Uh oh!

thefossguy-ciq commented Jun 7, 2025

Uh oh!

bmastbergen commented Jun 10, 2025

Uh oh!

github-actions bot commented Aug 8, 2025

Uh oh!

bmastbergen commented Aug 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

NO_MERGE This is an example PR with an upstream commit checker github action #323

NO_MERGE This is an example PR with an upstream commit checker github action #323

Uh oh!

Conversation

bmastbergen commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PlaidCat Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

bmastbergen Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bmastbergen Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

bmastbergen commented Jun 6, 2025

Uh oh!

thefossguy-ciq commented Jun 7, 2025

Uh oh!

bmastbergen commented Jun 10, 2025

Uh oh!

github-actions bot commented Aug 8, 2025

🔍 Upstream Linux Kernel Commit Check

Uh oh!

bmastbergen commented Aug 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

bmastbergen commented Jun 6, 2025 •

edited

Loading

bmastbergen Jun 6, 2025 •

edited

Loading