Resolve issue with intermittant access to patternfly assets #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses intermittent issues with accessing PatternFly assets during development by adding webpack configuration to properly resolve asset paths.
Key Changes
- Added PatternFly assets path to
resolve-url-loaderroot configuration to support CSS url() resolution - Refactored webpack alias configuration to dynamically compute aliases for PatternFly assets
- Added try-catch wrapper around alias computation to handle potential resolution failures
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dev, it is occasionally fail on new dev installs when starting npm, saying that it couldn't access the patternfly assets. They are clearly installed, so adding an alias to point to them as a stop gap.