Skip to content

Conversation

@sgtoj
Copy link
Contributor

@sgtoj sgtoj commented Dec 8, 2025

No description provided.

@sgtoj sgtoj requested a review from Copilot December 8, 2025 01:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the Okta SDK from v2 to v6, requiring significant changes to adapt to the new SDK's API structure and data types. The upgrade necessitates handling profile types differently (supporting both OktaUserGroupProfile and OktaActiveDirectoryGroupProfile) and using getter methods instead of direct field access.

  • Migration from Okta SDK v2 to v6 with updated import paths and API client initialization
  • Refactored group and user data access to use getter methods and handle multiple profile types
  • Updated test fixtures to include additional required fields for v6 SDK compatibility

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File Description
go.mod Updates Okta SDK dependency from v2.20.0 to v6.0.1 and associated transitive dependencies
internal/okta/client.go Refactors client initialization for v6 SDK, adds custom server configuration for testing, and updates API method calls to use new v6 patterns
internal/okta/groups.go Changes group handling to support multiple profile types and uses getter methods instead of direct field access
fixtures/scenarios.json Expands test fixture JSON responses with additional required fields for v6 SDK compatibility

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sgtoj sgtoj merged commit 333bf25 into main Dec 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants