Fix Vertex AI Global Endpoint URL Construction #553
+29
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When configuring
RubyLLMwithvertexai_location: "global", theVertexAIprovider incorrectly constructs the API URL ashttps://global-aiplatform.googleapis.com/v1beta1. This hostname does not exist, causing requests to fail with a 404 error.According to the Google Cloud Vertex AI documentation, the global endpoint should use the base hostname
https://aiplatform.googleapis.com/v1beta1without a location prefix.Solution
Updated
RubyLLM::Providers::VertexAI#api_baseto handle"global"as a special case:https://aiplatform.googleapis.com/v1beta1https://{location}-aiplatform.googleapis.com/v1beta1(e.g.,us-central1)Changes
lib/ruby_llm/providers/vertexai.rbto conditionally build the base URL.spec/ruby_llm/providers/vertexai_spec.rbto verify the URL construction logic for both global and regional configurations.Verification
globalvsus-central1locations.