Skip to content

Conversation

@ClausKlein
Copy link
Contributor

build on OS-latest with newest setup-cpp version

ymllint all files

fix typos and strip WS

@ClausKlein ClausKlein marked this pull request as draft September 6, 2023 20:30
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 10.52%. Comparing base (759d718) to head (c5c9c7b).
⚠️ Report is 47 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (759d718) and HEAD (c5c9c7b). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (759d718) HEAD (c5c9c7b)
Linux 9 5
Windows 5 3
Additional details and impacted files
@@             Coverage Diff              @@
##           develop      #69       +/-   ##
============================================
- Coverage    20.76%   10.52%   -10.24%     
============================================
  Files            5        3        -2     
  Lines          236      209       -27     
  Branches       131      131               
============================================
- Hits            49       22       -27     
+ Misses         180      173        -7     
- Partials         7       14        +7     
Flag Coverage Δ
Linux 10.52% <ø> (+0.52%) ⬆️
Windows ∅ <ø> (∅)
macOS 11.76% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lefticus
Copy link
Member

This looks pretty good and does fix MacOS it seems, is there a reason it's still marked as draft? @ClausKlein

@ClausKlein
Copy link
Contributor Author

This looks pretty good and does fix MacOS it seems, is there a reason it's still marked as draft? @ClausKlein

Perhaps to squash it?

build on OS-latest with newest setup-cpp version

ymllint all files

Fix typos and strip WS

Add path to gcovr

Use setup-cpp v0.35.2
@ClausKlein ClausKlein force-pushed the feature/update-ci-builds branch from de32c83 to c5c9c7b Compare March 18, 2024 19:08
@ClausKlein ClausKlein marked this pull request as ready for review March 18, 2024 19:09
@lefticus lefticus changed the base branch from main to develop March 19, 2024 23:09
@lefticus
Copy link
Member

I moved the base to develop then will take another look at these now failing tests again.

@lefticus lefticus deleted the branch cpp-best-practices:develop January 2, 2026 17:36
@lefticus lefticus closed this Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants