-
Notifications
You must be signed in to change notification settings - Fork 43
add .dockerignore file
#3066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add .dockerignore file
#3066
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. I'll fix the task violation if no one else is doing it..
Update: I think #3065 is what we need.
|
FYI there's a typo in commit message: -This commit adds a `.dockerfile`
+This commit adds a `.dockerignore` |
9a40011 to
ba4449c
Compare
This commit adds a `.dockerignore` which ignores the `dist/` directory when executing the `COPY . .` command in the `Dockerfile` and `Dockerfile.dist` file when building images. The expectation is that this will resolve the disk usage issues we're seeing. Ref: EC-1585 Signed-off-by: Rob Nester <rnester@redhat.com>
ba4449c to
bb3f142
Compare
Fixed. |
User description
This commit adds a
.dockerignorewhich ignores thedist/directory when executing theCOPY . .command in theDockerfileandDockerfile.distfile when building images. The expectation is that this will resolve the disk usage issues we're seeing.Ref: EC-1585
PR Type
Enhancement
Description
Add
.dockerignorefile to exclude unnecessary build artifactsPrevents
dist/directory from being copied into Docker imagesExcludes coverage, node modules, IDE files, and test artifacts
Resolves disk usage issues in multi-arch Docker builds
Diagram Walkthrough
File Walkthrough
.dockerignore
Create .dockerignore with build artifact exclusions.dockerignore
.dockerignorefile with Apache 2.0 license headerdist/directory to prevent host binaries from being copied*.out), node modules, IDE files, and testartifacts