feat: Reload postfix config without terminating connections #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a system administrator I would like to apply configuration changed for postfix by reloading it.
Before this PR, puppet restarts the postfix service which leads to terminated connections for clients on config changes.
Only in rare situations a restart of postfix is required to make changes effectiv: http://www.postfix.org/postconf.5.html
Changing the restart command to reload is also non-breaking as puppet starts a stopped service on notification by other/depending resources.
The default restart command is using systemd as it's the default service management on modern systems.
This may be has to be reworked when rebasing babiel/puppet-postfix on bodgit/puppet-postfix to bring this improvement to upstream, but at the moment both projects diverge a lot which will require additional work in the future.