Skip to content

Conversation

@delexagon
Copy link
Collaborator

Summary

  • Escaped search string regex (now searches exact string match)
  • Removed padding on <mark> elements

Screenshots

Captura de pantalla_20251216_184145

Known issues

None

Steps to test/reproduce

  1. Navigate to hearing transcript page
  2. Check that search functionality is functional
  3. Ensure that search highlighting does not space out text
  4. Ensure regex special characters ('.', '(', etc) search normally

@vercel
Copy link

vercel bot commented Dec 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
maple-dev Ready Ready Preview, Comment Dec 16, 2025 11:51pm

Copy link
Collaborator

@Mephistic Mephistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for finding this! Shame that https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/escape#browser_compatibility is still sitting below 80% on caniuse, but this seems like it will cover us until the availability picks up.

@Mephistic Mephistic merged commit 13a748c into codeforboston:main Dec 17, 2025
7 checks passed
@delexagon delexagon deleted the transcript-search-fix branch December 17, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants