Skip to content

feat: replace .expect() and .unwrap() with proper error handling #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
code-inflation wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: replace .expect() and .unwrap() with proper error handling #252

code-inflation wants to merge 3 commits into from

Conversation

@code-inflation
Copy link
Owner

@code-inflation code-inflation commented Dec 9, 2025

This MR replaces all .expect() and .unwrap() calls with proper error handling throughout the codebase.

Changes Made:

Error Handling Improvements:

  • Server-Timing Header Parsing: Added graceful fallback when header is missing or malformed
  • IP Address Parsing: Added meaningful error messages for invalid IPv4/IPv6 addresses
  • Client Initialization: Added proper error handling for reqwest client builder failures
  • HTTP Request Handling: Added error handling for upload/download request failures

New Tests Added:

  • IP address parsing error handling tests (valid/invalid IPv4/IPv6)
  • Client initialization error handling tests
  • HTTP request failure handling tests
  • Server-Timing header parsing tests (various scenarios)

Benefits:

  • No more panics: Application handles errors gracefully
  • Better UX: Clear error messages instead of cryptic panics
  • More robust: Continues running even when some features fail
  • Better debugging: Log messages help identify issues
  • Production ready: Much more suitable for real-world use

Testing:

  • All existing tests still pass (32 tests)
  • Added 5 new tests for error handling scenarios
  • No clippy warnings
  • Builds successfully in both debug and release modes

Breaking Changes:

None - this is a pure improvement with no API changes.

code-inflation and others added 2 commits December 9, 2025 22:19
@code-inflation @mistral-vibe
feat: replace .expect() and .unwrap() with proper error handling
250dfa2 
- Fix Server-Timing header parsing with graceful fallback
- Fix IP address parsing with meaningful error messages
- Fix client initialization with proper error handling
- Fix HTTP request handling with graceful degradation
- Add comprehensive tests for error handling scenarios
- Add Server-Timing header parsing tests
- Add Default implementation for SpeedTestCLIOptions

The application now handles errors gracefully instead of panicking,
providing better user experience and more robust operation.

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
@code-inflation @mistral-vibe
fix: apply cargo fmt formatting fixes
dfc3cf8 
Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
@code-inflation code-inflation force-pushed the feature/improved-error-handling branch from 286ff61 to 9223ee9 Compare December 27, 2025 16:29
@code-inflation code-inflation force-pushed the feature/improved-error-handling branch from 9223ee9 to e3b6c21 Compare December 27, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@code-inflation