Fix: cinema mode toggle leads to black screen #3518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amankumarconnect
force-pushed
the
fix-cinema-mode
branch
from
ff9a532 to
8b3ac46
Compare
|
This is still happening for me on Firefox... |
Contributor
Author
@drc0369 The PR is not merged yet. Only after it's merged, you will see the changes. |
Contributor
|
Apologies for the regression. Too many permutations to test :( |
Member
|
hello @amankumarconnect thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3517
Issue
The issue was that when the window width is greater than 1000px (likely in Default view rather than Theater mode), the YouTube player is contained within [player-container] instead of [player-full-bleed-container]. The extension's cinema mode was only bringing [player-full-bleed-container] to the front (z-index 10000), leaving [player-container] behind the black overlay (z-index 9999), resulting in a black screen.
Changes
I have updated [player.js] to target both [player-full-bleed-container] and [player-container] when toggling cinema mode. This ensures that the active player container is always brought above the overlay.
Files Modified:
[player.js]: Updated ImprovedTube.
playerCinemaModeButton, ImprovedTube.playerCinemaModeDisable, and [ImprovedTube.playerCinemaModeEnable] to handle both player container IDs.
Screenshot