Add unit tests for coriolisclient.v1.* modules
#87
Conversation
Cristi1324
force-pushed
the
add_v1_unit_tests_2
branch
from
1483fc7 to
6983cc9
Compare
| result = self.licence.list(mock.sentinel.appliance_id) | ||
|
|
||
| self.assertEqual( | ||
| mock_resource_class.return_value, |
There was a problem hiding this comment.
Please fix this duplicate line bug. Because you set the expected value twice, the actual result got passed as message to assertEqual.
| period, | ||
| expected_result, | ||
| raises, | ||
| has_logs |
There was a problem hiding this comment.
Since it's not an edgeg-case to log warnings in this method, we don't really care if logs are outputted. You can remove it and therefore simplify this test.
| ("1234567890123456789", None, True, True), | ||
| ("abc", None, True, True), | ||
| ("", None, True, True), | ||
| ("10s", mock.ANY, False, True), |
There was a problem hiding this comment.
Put a timestamp result here please. You could achieve this by mocking datetime.datetime.utcnow, that way you have a predefined time, and can anticipate the resulting period timestamp.
| mock_get | ||
| ): | ||
| logs_path = os.path.dirname(os.path.realpath(__file__)) | ||
| logs_path = os.path.join(logs_path, 'data') |
There was a problem hiding this comment.
Please setup a tempfile instead of pushing test results to repository :) https://docs.python.org/3/library/tempfile.html
…n period is string
Cristi1324
force-pushed
the
add_v1_unit_tests_2
branch
2 times, most recently
from
d281a2b to
5a7078a
Compare
Cristi1324
force-pushed
the
add_v1_unit_tests_2
branch
from
5a7078a to
b41f349
Compare
Dany9966
left a comment
Dany9966
left a comment
There was a problem hiding this comment.
LGTM. Will merge after the previous PR is also merged (this one has __init__.py missing in tests/v1.
2 participants
This PR adds unit tests for coriolisclient.v1.licensing...logging modules.