Fixed issue with yum package module regarding packages with epoch not validating #2970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigcomstock
force-pushed
the
ENT-12538/master
branch
from
47d320a to
39241f4
Compare
craigcomstock
force-pushed
the
ENT-12538/master
branch
from
af63318 to
18bee76
Compare
Contributor
Author
|
Will fix acceptance_tests and check valgrind_tests. |
… validating Packages would be installed but the promise would fail due to the installed list not including the epoch number. The updates list generated by the module included the epoch number so validation would fail. e.g. findutils:1:4.8.0-7.el9:x86_64 would not match findutils:4.8.0-7.el9:x86_64 Fix this by including epoch in rpm_output_format and removing (none): where the package has no epoch. Ticket: ENT-12538 Changelog: title
craigcomstock
force-pushed
the
ENT-12538/master
branch
from
18bee76 to
32110fe
Compare
Member
nickanderson
left a comment
nickanderson
left a comment
There was a problem hiding this comment.
Makes sense to me but not a good person to judge the code
Contributor
Author
Thanks! I requested a few python coders review. |
larsewi
approved these changes
Dec 19, 2024
Contributor
larsewi
left a comment
larsewi
left a comment
There was a problem hiding this comment.
s/valgring/valgrind/g in second commit. Looks good 🚀
Ticket: none Changelog: none
Ticket: ENT-12538 Changelog: none
craigcomstock
force-pushed
the
ENT-12538/master
branch
from
10ff75f to
ce1fac4
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.