CFE-2528: Changed the default for allowallconnects #2969
Conversation
|
@cf-bottom let's build this in jenkins |
olehermanse
changed the title
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/11497/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11497/ |
nickanderson
left a comment
nickanderson
left a comment
There was a problem hiding this comment.
I did not realize that in the MPF we have been enabling this by default. It's apparently been that way for quite some time: https://github.com/cfengine/masterfiles/blame/b8e31ade3e27dd7916400816b94f01f40264eb1d/controls/cf_serverd.cf#L16
I do support disabling this by default.
I also support a better configuration option that is somewhere between all or nothing, e.g. being able to limit concurrency to say 5 connections per client instead of allow unlimited parallel connections or allow only a single connection.
allowallconnects should be for allowing parallel connections. Let's see if this is really necessary, since cf-agent should reuse an open connection and this shouldn't be needed, at least by default. Ticket: CFE-2528 Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
|
@cf-bottom jenkins, please |
olehermanse
changed the title
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/11586/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11586/ |
4 participants
allowallconnects should be for allowing parallel connections.
Let's see if this is really necessary, since cf-agent should
reuse an open connection and this shouldn't be needed, at least
by default.