rename fixed size list to fixed-length lists #2421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
PS: I am not able to add this to Implement WIT Fixed-Length-Lists but it belongs there. |
alexcrichton
requested review from
alexcrichton
and removed request for
pchickey
Member
|
CI failure looks unrelated to this PR, I'll investigate soon |
alexcrichton
approved these changes
Jan 20, 2026
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Thanks! With #2422 CI should be fixed now, mind rebasing?
cpetig
force-pushed
the
fixed_length_rename
branch
from
561972e to
e77bc56
Compare
github-project-automation
bot
moved this from Todo
to Done
in Implement WIT Fixed-Length-Lists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up while designing the patches in wasmtime and wit-bindgen, the feature is not named in accordance with the spec and if we ever would like to rename it, it should be now or never. Because right now the feature is in little use but will be used more widely soon.
I recall talking with @alexcrichton about this somewhere before (couldn't find it) and we decided that it wasn't worth the extra effort. But with this patch available the scale might tip - it feels less weird to have it named fixed-length list everywhere.
This will require matching patches in wit-bindgen, wac, and wasmtime once these upgrade to this wasm-tools version.