Skip to content

Conversation

@MrWad3r
Copy link
Member

@MrWad3r MrWad3r commented Jul 24, 2025

Pull Request Checklist

NODE CONFIGURATION MODEL CHANGES

[None] / [Yes]

BLOCKCHAIN CONFIGURATION MODEL CHANGES

[None] / [Yes]


COMPATIBILITY

Affected features:

  • [State]
  • [State. Blockchain Config]
  • [Block]
  • [Block Proof]
  • [Archive]
  • [Persistent State]
  • [Persistent Queue]
  • [Storage. Blocks]
  • [Storage. States]
  • [Storage. Archives]
  • [Queue. Diff]
  • [Queue. Storage]
  • [Queue. Storage. Statistics]
  • [Message Processing Algorithm]
  • [ProcessedUpto]
  • [Collator. Limits]
  • [Collator. Work Units Calculation]
  • [Mempool. Consensus Config]
  • [Mempool. Validation rules]
  • [Mempool. Storage]
  • [Mempool. API tl models]

SPECIAL DEPLOYMENT ACTIONS

[Not Required] / [Required]


PERFORMANCE IMPACT

[No impact expected] / [Expected impact]


TESTS

Unit Tests

[Covered by:] / [No coverage]

Network Tests

[Covered by:] / [No coverage]

Manual Tests

[Manual tests used]

  • [1-255]
  • [transfers]
  • [swaps]

Notes/Additional Comments:

@github-actions
Copy link

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=837

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=837
  • Run specific test: gh workflow run network-tests.yml -f pr_number=837 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@SmaGMan
Copy link
Contributor

SmaGMan commented Jul 25, 2025

@MrWad3r Do we really need ability to change filter in collator? May be it would be more clear to add filter into mempool adapter itself and not to pass from collator?

@MrWad3r
Copy link
Member Author

MrWad3r commented Jul 25, 2025

@MrWad3r Do we really need ability to change filter in collator? May be it would be more clear to add filter into mempool adapter itself and not to pass from collator?

I will need several mempool adapters then with literally the same logic since collator is not the only place where filtration is used. Thus it does not seem much more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants