Fix some internal fatal errors not logged by forcing display_errors=1 in the bootstrap process
#267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
changed the title
display_errors=1 in the bootstrap processdisplay_errors=1 in the bootstrap process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
fpmruntime, fatal errors in the bootstrap process don't have their details logged.Reported in Slack: https://brefworkspace.slack.com/archives/C057S6G4Z9N/p1750813674579189?thread_ts=1750740077.495139&cid=C057S6G4Z9N
Here is to illustrate:
The reason is that
display_errors=0in the FPM runtime because we don't want errors in the application to be logged tostdout(becausestdoutis the HTTP response). However this is an issue in the bootstrap process: errors are then not logged (some errors, not all of them).This PR forces
display_errors=1in the bootstrap process regardless of the runtime.