-
Notifications
You must be signed in to change notification settings - Fork 1
fix: rename dart-analyzer plugin to dart-lsp #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add dart-analyzer LSP plugin using the Dart Analysis Server bundled with the Dart SDK. Includes Flutter-optimized initialization options and a session hook to verify SDK installation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Rename directory from dart-analyzer to dart-lsp - Update plugin.json name to dart-lsp - Update .lsp.json client-id to claude-code.dart-lsp 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
boostvolt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the addition. Some small comments. And pls add the dart-analyzer to the root README as well. Thanks!
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "name": "dart-lsp", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls make sure directory and name here is the same as in root marketplace.json -> dart-analyzer
| { | ||
| "name": "dart-lsp", | ||
| "description": "Dart/Flutter language server", | ||
| "version": "1.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls same version as in root marketplace.json -> 1.0.0
| { | ||
| "dart": { | ||
| "command": "dart", | ||
| "args": ["language-server", "--client-id=claude-code.dart-lsp", "--client-version=1.0.0"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls use same client id as plugin name defined in root marketplace.json -> dart-analyzer
| "onlyAnalyzeProjectsWithOpenFiles": false, | ||
| "suggestFromUnimportedLibraries": true, | ||
| "closingLabels": false, | ||
| "outline": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true by default -> remove
| }, | ||
| "transport": "stdio", | ||
| "initializationOptions": { | ||
| "onlyAnalyzeProjectsWithOpenFiles": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
false by default -> remove
| "suggestFromUnimportedLibraries": true, | ||
| "closingLabels": false, | ||
| "outline": true, | ||
| "flutterOutline": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true by default -> remove
| "transport": "stdio", | ||
| "initializationOptions": { | ||
| "onlyAnalyzeProjectsWithOpenFiles": false, | ||
| "suggestFromUnimportedLibraries": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure this option exists? doc link?
| "initializationOptions": { | ||
| "onlyAnalyzeProjectsWithOpenFiles": false, | ||
| "suggestFromUnimportedLibraries": true, | ||
| "closingLabels": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why against defaults here?
| "dart": { | ||
| "completeFunctionCalls": true, | ||
| "enableSnippets": true, | ||
| "showTodos": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again everything except showTodos is per default so it does not need to be set explicitly.
also why is showTodos against defaults?
Summary
dart-analyzertodart-lspfor consistencydart-lspclaude-code.dart-lspTest plan
🤖 Generated with Claude Code