Feature/twig deprecations remove #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielamorse
reviewed
Oct 5, 2023
composer.json
Outdated
| "name": "bolt-design-system/core-php", | ||
| "description": "Core PHP functionality for the Bolt Design System", | ||
| "version": "5.9.1", | ||
| "version": "5.9.2", |
Contributor
There was a problem hiding this comment.
Should we bump this to 8.0.0 to catch up with Bolt?
composer.json
Outdated
| "boltvcs": { | ||
| "type": "vcs", | ||
| "url": "https://github.com/boltdesignsystem/twig-tools", | ||
| "url": "https://github.com/sreenivasulu-paruchuri/twig-tools.git", |
Contributor
There was a problem hiding this comment.
Do you not have access to the bolt design system twig-tools repo? Or is this just temporary for testing?
composer.json
Outdated
| }, | ||
| "require": { | ||
| "basaltinc/twig-tools": "dev-master as 1.4.3", | ||
| "basaltinc/twig-tools": "1.4.4", |
Contributor
There was a problem hiding this comment.
Does 1.4.4 exist?
Contributor
|
@remydenton, @relimck should we be targeting the release/8.x branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed Twig 2.7 deprecations to work with Twig 3.x