Remove conscrypt #77
Merged
Remove conscrypt #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
There was a problem hiding this comment.
Pull Request Overview
This PR removes the Conscrypt dependency from the main library implementation and moves it to test scope only. The main changes replace the direct usage of Conscrypt's default trust manager with the standard Java TrustManagerFactory API for retrieving the system trust manager.
- Replaced
Conscrypt.getDefaultX509TrustManager()with standardTrustManagerFactoryAPI - Moved Conscrypt dependency from
implementationtoandroidTestImplementation - Reorganized test files to consolidate Conscrypt-related tests
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| CustomCertStore.kt | Replaced Conscrypt-specific trust manager retrieval with standard Java TrustManagerFactory API |
| CustomCertManager.kt | Removed Conscrypt initialization from companion object |
| OkhttpTest.kt | Moved Conscrypt initialization to @Before method and removed Conscrypt-specific test |
| ConscryptTest.kt | Deleted file (tests moved to ConscryptIntegrationTest.kt) |
| ConscryptIntegrationTest.kt | New file consolidating Conscrypt-related tests from other files |
| ConscryptIntegration.kt | New test utility file for initializing Conscrypt in tests |
| build.gradle.kts | Moved Conscrypt from implementation to androidTestImplementation dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ArnyminerZ
approved these changes
Nov 6, 2025
Member
ArnyminerZ
left a comment
ArnyminerZ
left a comment
There was a problem hiding this comment.
Looks good. Feel free to merge :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove conscrypt but keep it in integration tests. Projects using cert4android should themselves decide whether they want to use conscrypt or not.