Minor logging/output fixes #404
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error might not be due to a DB error, and anyhow, the DB error was already been displayed when it first occurred within $SubAttachment->Create(...).
Previously this was displayed: Transaction not committed. Usually indicates a software fault.Data loss may have occurred A little ugly.
There is no stringify function on RT::Transaction, so this is causing log entries like: [4044261] [Sat Nov 11 11:30:40 2023] [debug]: Calling SetRecipientDigests for transaction RT::Transaction=HASH(0x563feb2b4fb0), id 44 (lib/RT/Action/SendEmail.pm:693) Let's not have the RT::Transaction=HASH(0x563feb2b4fb0) in there.
I was having this test fail when malware scanning is enabled with: Use of uninitialized value $_ in concatenation (.) or string at t/web/charting.t line 14. In perlsyn under https://perldoc.perl.org/perlsyn#Foreach-Loops it says: The foreach keyword is actually a synonym for the for keyword, so you can use either. If VAR is omitted, $_ is set to each value. VAR is set (it is $n), so perhaps this usage of $_ while VAR is set is undefined.
puck
force-pushed
the
minor-logging-fixes
branch
from
6dc77b2 to
e4ef7b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor logging/output fixes that I've spotted while development some extra functionality for RT.
This should also apply cleanly against 5.0-trunk (that's where I've been developing against).