Skip to content

Return process object asynch #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mariadb-JeffBachtel wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Return process object asynch #98

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bec2c94
Update the cmd return type
mariadb-JeffBachtel Mar 2, 2021
fc13c32
Return the Popen object for synchronous=True
mariadb-JeffBachtel Mar 2, 2021
4a43cd4
make python 3.6-3.8 compat
mariadb-JeffBachtel Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python_terraform/terraform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class IsNotFlagged(TerraformFlag):
pass


CommandOutput = Tuple[Optional[int], Optional[str], Optional[str]]
CommandOutput = Tuple[Union[int, subprocess.Popen, None], Optional[str], Optional[str]]


class TerraformCommandError(subprocess.CalledProcessError):
Expand Down Expand Up @@ -342,7 +342,7 @@ def cmd(
)

if not synchronous:
return None, None, None
return p, None, None

out, err = p.communicate()
ret_code = p.returncode
Expand Down