Skip to content

Add helper function to get the supported locales excluding mappings #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Erikvv wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add helper function to get the supported locales excluding mappings #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/SlmLocale/Locale/Detector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,14 @@ class Detector implements EventManagerAwareInterface
/**
* Optional list of supported locales
*
* @var array
* @var string[]
*/
protected $supported;

/**
* Optional list of locale mappings
*
* @var array
* @var array & string[string]
Copy link
Collaborator

@svycka svycka Jun 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be array and maybe add an example or/and description

*/
protected $mappings;

Expand Down Expand Up @@ -128,6 +128,21 @@ public function hasSupported()
return is_array($this->supported) && count($this->supported);
}

/**
* get the supported locales excluding those which are mapped to another locale
*
* @return string[]
*/
public function getMainSupportedLocales()
{
$supported = $this->getSupported() ?: [];
$mappings = $this->getMappings() ?: [];

$mappedFrom = array_keys($mappings);

return array_values(array_diff($supported, $mappedFrom));
}

public function getMappings()
{
return $this->mappings;
Expand Down
26 changes: 26 additions & 0 deletions tests/SlmLocaleTest/Locale/DetectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,32 @@ public function testEmptyMappingsListIndicatesNoMappingsList()
$this->assertFalse($detector->hasMappings());
}

public function testMainSupportedLocalesExcludesMappings()
{
$detector = new Detector();
$detector->setSupported([
'nl',
'nl_NL',
]);

$detector->setMappings([
'nl' => 'nl_NL',
]);

$this->assertEquals(['nl_NL'], $detector->getMainSupportedLocales());
}

public function testMainSupportedLocalesWithoutMappings()
{
$detector = new Detector();
$detector->setSupported([
'nl',
'nl_NL',
]);

$this->assertEquals(['nl', 'nl_NL'], $detector->getMainSupportedLocales());
}

public function testStrategyAttachesToEventManager()
{
$detector = new Detector();
Expand Down