Skip to content

feat: add rules for java.time.Local* and java.time.ZonedDateTime #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobixlea merged 3 commits into from
Dec 9, 2025
Merged

feat: add rules for java.time.Local* and java.time.ZonedDateTime #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e34f29
SystemTimeMillis
tobixlea Dec 8, 2025
9d6a6bf
Update tests to reflect new changes
tobixlea Dec 9, 2025
0a08c36
Update assert statements with new hard coded lines
tobixlea Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/main/java/software/amazon/lambda/snapstart/ByteCodeIntrospector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,14 @@ public class ByteCodeIntrospector {

private static final String INSTANT_SIGNATURE = "Ljava/time/Instant;";

private static final String LOCAL_DATE_TIME_SIGNATURE = "Ljava/time/LocalDateTime;";

private static final String LOCAL_DATE_SIGNATURE = "Ljava/time/LocalDate;";

private static final String LOCAL_TIME_SIGNATURE = "Ljava/time/LocalTime;";

private static final String ZONED_DATE_TIME_SIGNATURE = "Ljava/time/ZonedDateTime;";

private static final Map<String, Set<String>> TIMESTAMP_METHODS = new HashMap<String, Set<String>>() {{
put("java.lang.System", setOf("currentTimeMillis", "nanoTime"));
}};
Expand Down Expand Up @@ -188,6 +196,18 @@ boolean isTimestamp(OpcodeStack stack) {
if (INSTANT_SIGNATURE.equals(stack.getStackItem(0).getSignature())) {
return true;
}
if (LOCAL_DATE_TIME_SIGNATURE.equals(stack.getStackItem(0).getSignature())) {
return true;
}
if (LOCAL_DATE_SIGNATURE.equals(stack.getStackItem(0).getSignature())) {
return true;
}
if (LOCAL_TIME_SIGNATURE.equals(stack.getStackItem(0).getSignature())) {
return true;
}
if (ZONED_DATE_TIME_SIGNATURE.equals(stack.getStackItem(0).getSignature())) {
return true;
}
XMethod xMethod = stack.getStackItem(0).getReturnValueOf();
if (xMethod != null) {
Set<String> methodNames = TIMESTAMP_METHODS.get(xMethod.getClassName());
Expand Down
16 changes: 10 additions & 6 deletions src/test/java/software/amazon/lambda/snapstart/LambdaHandlerInitedWithRandomValueTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,13 +113,17 @@ public void timestampMemberFieldBreaksSnapStart() {
BugCollection bugCollection = findBugsInClasses("LambdaUsingTs");
BugInstanceMatcherBuilder bugMatcherBuilder = snapStartBugMatcher().inClass("LambdaUsingTs");

assertThat(bugCollection, containsExactly(1, bugMatcherBuilder.atField("tsFromSystemTimeMillis").atLine(24).build()));
assertThat(bugCollection, containsExactly(1, bugMatcherBuilder.atField("tsFromSystemTimeNano").atLine(25).build()));
assertThat(bugCollection, containsExactly(1, bugMatcherBuilder.atField("tsFromInstantNow").atLine(26).build()));
assertThat(bugCollection, containsExactly(1, bugMatcherBuilder.atField("tsFromClock").atLine(27).build()));
assertThat(bugCollection, containsExactly(1, bugMatcherBuilder.atField("tsFromSystemTimeMillis").atLine(32).build()));
assertThat(bugCollection, containsExactly(1, bugMatcherBuilder.atField("tsFromSystemTimeNano").atLine(33).build()));
assertThat(bugCollection, containsExactly(1, bugMatcherBuilder.atField("tsFromInstantNow").atLine(34).build()));
assertThat(bugCollection, containsExactly(1, bugMatcherBuilder.atField("tsFromClock").atLine(35).build()));
assertThat(bugCollection, containsExactly(1, bugMatcherBuilder.atField("tsFromLocalDateTimeNow").atLine(36).build()));
assertThat(bugCollection, containsExactly(1, bugMatcherBuilder.atField("tsFromLocalDateNow").atLine(37).build()));
assertThat(bugCollection, containsExactly(1, bugMatcherBuilder.atField("tsFromLocalTimeNow").atLine(38).build()));
assertThat(bugCollection, containsExactly(1, bugMatcherBuilder.atField("tsFromZonedDateTimeNow").atLine(39).build()));
toBeFixed(() -> assertThat(bugCollection, containsExactly(1, bugMatcherBuilder.atField("logName").atLine(29).build())));
assertThat(bugCollection, containsExactly(4, snapStartBugMatcher().build()));
toBeFixed(() -> assertThat(bugCollection, containsExactly(5, snapStartBugMatcher().build())));
assertThat(bugCollection, containsExactly(8, snapStartBugMatcher().build()));
toBeFixed(() -> assertThat(bugCollection, containsExactly(9, snapStartBugMatcher().build())));
}

@Test
Expand Down
17 changes: 17 additions & 0 deletions src/test/java/software/amazon/lambda/snapstart/lambdaexamples/LambdaUsingTs.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@
import com.amazonaws.services.lambda.runtime.RequestHandler;
import java.time.Clock;
import java.time.Instant;
import java.time.LocalDateTime;
import java.time.LocalDate;
import java.time.LocalTime;
import java.time.ZonedDateTime;
import java.util.Map;

public class LambdaUsingTs implements RequestHandler<Map<String,String>, String> {
Expand All @@ -19,12 +23,21 @@ public class LambdaUsingTs implements RequestHandler<Map<String,String>, String>
private long tsFromSystemTimeNano;
private Instant tsFromInstantNow;
private Instant tsFromClock;
private LocalDateTime tsFromLocalDateTimeNow;
private LocalDate tsFromLocalDateNow;
private LocalTime tsFromLocalTimeNow;
private ZonedDateTime tsFromZonedDateTimeNow;

public LambdaUsingTs(Clock clock) {
tsFromSystemTimeMillis = System.currentTimeMillis(); // This is a bug
tsFromSystemTimeNano = System.nanoTime(); // This is a bug
tsFromInstantNow = Instant.now(); // This is a bug
tsFromClock = clock.instant(); // This is a bug
tsFromLocalDateTimeNow = LocalDateTime.now(); // This is a bug
tsFromLocalDateNow = LocalDate.now(); // This is a bug
tsFromLocalTimeNow = LocalTime.now(); // This is a bug
tsFromZonedDateTimeNow = ZonedDateTime.now(); // This is a bug


logName = getLogName(); // This is a bug
}
Expand All @@ -40,6 +53,10 @@ public String handleRequest(Map<String, String> event, Context context) {
out.println(tsFromSystemTimeNano);
out.println(tsFromInstantNow);
out.println(tsFromClock);
out.println(tsFromLocalDateTimeNow);
out.println(tsFromLocalDateNow);
out.println(tsFromLocalTimeNow);
out.println(tsFromZonedDateTimeNow);
return "200";
}
}