Support for tagging GameLift builds when using upload-build command #6088
+391
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonnixs
changed the title
…d resource when using upload-build command
kdaily
added
customization
kdaily
added
gamelift-uploadbuild
and removed
service-api
2 tasks
2 tasks
Contributor
|
Hi @jonnixs, thanks for the PR. Our team just put out a contribution guide detailing improvements to the contribution process. I have created issue #6927 for this PR. We will wait for the issue to receive 10 upvotes before moving this PR into the ready-for-review stage on our project board. The rationale for this can be found in the rationale section of the contribution guide. |
Member
|
Hi @jonnixs - thanks again for your contribution here, and we apologize for the delay. The GameLift team proposed an alternative syntax for the tags, which matches other places that the AWS CLI exposes custom tagging. We're going to merge their PRs soon, so I'm going to close this one out. See #9981 and #9998 for the changes we are planning to release. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#6927
Description of changes:
Currently the upload-build command for GameLift is recommended over using create-build then uploading separately. However, while create-build supports the adding of tags to the build, upload-build does not, causing problems if request tag based conditions on IAM policies are in place.
This pull request adds the option to provide tag lists of key-value pairs to the upload-build command which passes them to the create_build method which already supports the Tags option.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.