Skip to content

Conversation

@aemous
Copy link
Contributor

@aemous aemous commented Jan 21, 2026

Description of changes:

  • Deleted modeled suggested_manual_fix property from LintFinding, and removed the property from all classes that specified one. This change is based on feedback that the manual-review findings were too verbose.
  • Added two new options to interactive mode: accept all of type and reject all of type, which accepts and rejects all remaining findings for the displayed rule, respectively.
  • Added 5 new tests for interactive mode for the two new options.
  • Replace use of | with for the margin when displaying diffs, for an improved appearance.
  • Improved spacing between findings in interactive mode, and before the first finding in dry-run mode and auto-fix mode.
  • Upgraded the version of ast-grep-py dependency to 0.40.5.
  • Removed contribution guidelines from the README and moved it to a new file CONTRIBUTING.md.
  • Added new "Supported Breaking Changes" and "Backwards Compatibility Policy" sections to the README.
  • Updated tests based on the changes above.
  • Updated the uv.lock file based on automatically generated changes.

Description of tests:

  • Successfully ran and passed all tests and linters.
  • Manually tested the migration tool across all modes using the example script, and observed expected behavior.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aemous aemous requested a review from a team January 21, 2026 20:14
…rate development guidelines to a new CONTRIBUTING.md file.
@aemous aemous marked this pull request as ready for review January 21, 2026 21:33
@kdaily kdaily self-requested a review January 21, 2026 22:26
@kdaily kdaily self-assigned this Jan 21, 2026
Copy link
Member

@kdaily kdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!

Minor comments:

Some of the added printing/formatting is a bit awkward, going inside some of the higher level methods that apply fixes, instead of being inside display/print methods. Consider if there's a way to move the formatting logic inside for easier focus. Wouldn't block it for that though.

@aemous
Copy link
Contributor Author

aemous commented Jan 22, 2026

Some of the added printing/formatting is a bit awkward, going inside some of the higher level methods that apply fixes, instead of being inside display/print methods. Consider if there's a way to move the formatting logic inside for easier focus. Wouldn't block it for that though.

I have refactored auto-fix and dry-run modes so that they do not interleave prints with script updates. Now, it collects all the findings while updating the script, and then it prints all the findings and results at the end. This separates printing from core logic.

@aemous aemous requested a review from kdaily January 22, 2026 18:14
@kdaily
Copy link
Member

kdaily commented Jan 22, 2026

Just want to confirm that the intention to have the base64-binary-format and no-cli-pager as interactive fixes from separate discussions matches the implementation here. If I run in non-interactive mode (e.g., --fix) then changes for these rules are applied everywhere.

Other than that, this looks fine and tests locally as expected.

@aemous aemous merged commit 8adb623 into aws:v1v2-migration-tool Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants