-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Migration tool interactive mode updates #10009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration tool interactive mode updates #10009
Conversation
…tions to README.md
…rate development guidelines to a new CONTRIBUTING.md file.
kdaily
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall!
Minor comments:
Some of the added printing/formatting is a bit awkward, going inside some of the higher level methods that apply fixes, instead of being inside display/print methods. Consider if there's a way to move the formatting logic inside for easier focus. Wouldn't block it for that though.
…ool Issue template.
… are already collected.
I have refactored auto-fix and dry-run modes so that they do not interleave prints with script updates. Now, it collects all the findings while updating the script, and then it prints all the findings and results at the end. This separates printing from core logic. |
…re no issues in the input script.
|
Just want to confirm that the intention to have the base64-binary-format and no-cli-pager as interactive fixes from separate discussions matches the implementation here. If I run in non-interactive mode (e.g., Other than that, this looks fine and tests locally as expected. |
Description of changes:
suggested_manual_fixproperty fromLintFinding, and removed the property from all classes that specified one. This change is based on feedback that the manual-review findings were too verbose.|with│for the margin when displaying diffs, for an improved appearance.ast-grep-pydependency to0.40.5.CONTRIBUTING.md.uv.lockfile based on automatically generated changes.Description of tests:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.