chore(maintenance): general refactoring #4905
Merged
+1,958
−1,984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vements - Use nullish coalescing operator (??) instead of ternary for default values - Replace deprecated string methods with modern alternatives (replaceAll) - Simplify conditional logic and remove redundant ternary operators - Use direct function references instead of arrow wrapper functions - Improve import/export patterns for better tree-shaking - Add proper async/await patterns where needed - Fix inverted console setup logic in Logger and Metrics - Add NOSONAR comments for intentional code patterns - Extract constants to reduce duplication in test factories - Add sonar exclusions for generated proto files in kafka package
boring-cyborg
bot
added
commons
svozza
previously approved these changes
Jan 2, 2026
svozza
reviewed
Jan 2, 2026
SonarCloud flagged the replaceAll('\*', '.*') as a code smell suggesting
String.raw usage, but this is a false positive. The double backslash is
intentionally used to match literal backslash-asterisk sequences in paths.
…nces JMESPath compliance tests intentionally use literal escape sequences to test the parser's handling of backslash escaping. These are not candidates for String.raw conversion as they need to test specific escape behaviors.
pull-request-size
bot
added
size/XL
Biome formatter applied consistent formatting to test structure while preserving NOSONAR comments for escape sequence compliance tests.
pull-request-size
bot
added
size/XXL
dreamorosi
changed the title
svozza
reviewed
Jan 2, 2026
Co-authored-by: Stefano Vozza <svozza@amazon.com>
|
svozza
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This is a general maintenance PR driven primarily from SonarCloud minor findings that have accumulated over the past few quarters. Here's a non-exhaustive list of changes:
??) instead of ternary for default valuesreplaceAll)Issue number: closes #4904
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.