This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add limit option to findTags #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansonw
force-pushed
the
findTags-limit
branch
from
a166484 to
88087f8
Compare
Author
|
ping - @zcbenz maybe? We're using this in Nuclide, and it's difficult to make it performant on large tags files without limiting the result set. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional
limitoption tofindTagswhich allows the user to specify the maximum number of results returned. This saves a lot of computation with large tag files.Detailed semantics:
limitis undefined or null, it is ignored (unlimited results)limitmust be a positive integer, strictly enforced at runtime