This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add an option to cycle through bookmarks #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@solendil @nbigaouette what are your opinions on adding a visual cue that the beginning/end of the file has been reached and the bookmarks have looped? Similar to this PR from find-and-replace: atom/find-and-replace#572. |
|
This PR is exactly what I asked some time ago in #31. But even without it, the visual clue you suggest is an excellent idea. |
Author
|
Wrap around icon added. I didn't bother to put a screenshot because it is exactly the same than the one from the find-and-replace package. In fact I borrowed most of the code from there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues #31 and #50 show that not all users agree on the expected behavior when bottom of buffer has been reached. Should we cycle to top of buffer or stay at the bottom with a 'bip' for a better sense of place? This pull request implements an option (the first one for the bookmarks package!); default behavior is unchanged.
Feel free to change the wording; English is not my mother tongue.
Jasmine specs have been added.