loader: export symbols for Arduino_JSON library #266
+12
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Member
|
Hi @hajimef , thanks for the contribution! I'd move |
facchinm
requested changes
Nov 17, 2025
Member
facchinm
left a comment
facchinm
left a comment
There was a problem hiding this comment.
As per comment, plus need to fix the commit message before merging
hajimef
commented
Nov 17, 2025
Author
hajimef
left a comment
hajimef
left a comment
There was a problem hiding this comment.
Thank you for comment.
I moved the line as you suggested.
I then tried the Adafruit NeoPixel library and found that I also needed to add strtol, so I added that line as well.
facchinm
force-pushed
the
topic_arduino_json
branch
from
5630ffb to
dbb4842
Compare
facchinm
changed the title
facchinm
approved these changes
Nov 18, 2025
facchinm
force-pushed
the
topic_arduino_json
branch
from
dbb4842 to
a93b329
Compare
pillo79
reviewed
Nov 18, 2025
platform.txt
Outdated
| build.link_command="{compiler.path}{compiler.c.elf.cmd}" "-L{build.path}" "-L{build.variant.path}" {compiler.c.elf.flags} {compiler.c.elf.extra_flags} {build.extra_flags} {build.extra_ldflags} {compiler.zephyr.common_ldflags} --specs=picolibc.specs --specs=nosys.specs {compiler.ldflags} {object_files} -Wl,--start-group "{build.path}/{archive_file}" {compiler.zephyr.extra_ldflags} {compiler.libraries.ldflags} -Wl,--end-group {build.link_args.{build.link_mode}} | ||
|
|
||
| build.check_command-dynamic={build.link_command} {build.link_args.check-dynamic} -o "{build.path}/{build.project_name}_check.tmp" | ||
| build.check_command-dynamic={build.link_command} -lc -lm -lgcc {build.link_args.check-dynamic} -o "{build.path}/{build.project_name}_check.tmp" |
There was a problem hiding this comment.
Those added libraries are not used in the final link stage, so this change masks actual build errors AFAICS. What am I missing?
Author
There was a problem hiding this comment.
I built it with the 0.51.0 tag.
And the target was arduino_uno_q.
This may be the cause.
Minor fixes for Arduino_JSON library compatibility: - '__assert_no_args' and 'exit' are actually libc symbols, so the guards prevented their export in certain situations. - _exit, stdin, stdout, stderr symbols are also exported to cover the dynamic link case. - an 'undefined reference to _ctype_' error occurred because the libc is compiled with -Os, while the sketches are NOT - this creates an issue because the size optimization auto-selects a different version of ctype functions in picolibc. -D_PICOLIBC_CTYPE_SMALL=1 forces the small version to be used. Signed-off-by: Luca Burelli <l.burelli@arduino.cc>
pillo79
force-pushed
the
topic_arduino_json
branch
from
f21b6b0 to
7037c1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the Arduino_JSON library (https://github.com/arduino-libraries/Arduino_JSON), I encountered the error "llext: Undefined symbol with no entry in symbol table."
So I added the necessary symbols.