Skip to content

Conversation

@kevin-tricot
Copy link

What does this PR do?

Update our pronto-ruby project to the latest (based on Renato's work)

Associated ticket number and/or AirBrake error?

N/A

Due Date or Desirable Merge

Not urgent

How has this been tested?

Locally

Anticipated impact

No anticipated impact except being up to date!

How do you plan to monitor the change in prod to make sure it's working?

N/A

Checklist

  • My code follows the code style of this project.
  • I have run tests locally (manual tests and otherwise).
  • This has been tested on staging.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change includes a database modification
    • I have tested my database modification in staging.
  • My change breaks API retrocompatibility.
    • I have notified the frontend developers concerned about this change.
    • I have notified the public API consumers about this change. (DataPi)
  • My change touches on some of the following areas: authorizing access to integration data (consoles, search ads, MMP), authentication (including serving or consuming OAuth endpoints), cryptography and security (including generation of secure tokens). If so:
    • I am tagging a senior reviewer to specifically review the security of this change: (flag reviewer here)
  • My changes require changes in other components/squads/teams
    • I already did the changes in the other components or notified the responsible people that the changes need to be done
    • The needed changes are already deployed or ready to be deployed

@kevin-tricot kevin-tricot self-assigned this Dec 3, 2025
@kevin-tricot kevin-tricot requested a review from Dakad December 3, 2025 14:23
Copy link

@Dakad Dakad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this. 💪

@Dakad
Copy link

Dakad commented Dec 3, 2025

Do you mind if we merge this PR too, alongside yours? #15

@kevin-tricot
Copy link
Author

Do you mind if we merge this PR too, alongside yours? #15

Sure! Planning to do it tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants