Skip to content

[fix][ml] Fix NoSuchElementException in EntryCountEstimator caused by a race condition #25177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BewareMyPower merged 4 commits into from
Jan 23, 2026
Merged

[fix][ml] Fix NoSuchElementException in EntryCountEstimator caused by a race condition #25177

BewareMyPower merged 4 commits into from
Jan 23, 2026
+74 −11

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Jan 22, 2026

Fixes #25174

Motivation

An NoSuchElementException could occur in EntryCountEstimator, causing dispatching to stop.
This condition could happen as a result of a race condition caused by ledger trimming. The ledgersInfo map appear to be be empty.

Modifications

  • check if ledgersInfo map is empty
  • catch NoSuchElementException when firstKey or lastKey is accessed to avoid race conditions after checking if the map was empty
  • add tests

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.2.0 milestone Jan 22, 2026
@lhotari lhotari self-assigned this Jan 22, 2026
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 22, 2026
@lhotari lhotari added release/3.0.16 release/4.0.9 release/4.1.3 and removed doc-not-needed Your PR changes do not impact docs labels Jan 22, 2026
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 22, 2026
@lhotari lhotari mentioned this pull request Jan 22, 2026
Closed
3 tasks
Shawyeok
Shawyeok approved these changes Jan 22, 2026
View reviewed changes
Copy link
Contributor

@Shawyeok Shawyeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BewareMyPower BewareMyPower merged commit 9b70ba3 into apache:master Jan 23, 2026
53 of 55 checks passed
lhotari added a commit that referenced this pull request Jan 23, 2026
@lhotari
[fix][ml] Fix NoSuchElementException in EntryCountEstimator caused by…
bc3ea21 
… a race condition (#25177)

(cherry picked from commit 9b70ba3)
lhotari added a commit that referenced this pull request Jan 23, 2026
@lhotari
[fix][ml] Fix NoSuchElementException in EntryCountEstimator caused by…
4d3197e 
… a race condition (#25177)

(cherry picked from commit 9b70ba3)
lhotari added a commit that referenced this pull request Jan 23, 2026
@lhotari
[fix][ml] Fix NoSuchElementException in EntryCountEstimator caused by…
9261869 
… a race condition (#25177)

(cherry picked from commit 9b70ba3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BewareMyPower BewareMyPower BewareMyPower approved these changes

@Technoboy- Technoboy- Awaiting requested review from Technoboy-

@nodece nodece Awaiting requested review from nodece

@dao-jun dao-jun Awaiting requested review from dao-jun

+1 more reviewer

@Shawyeok Shawyeok Shawyeok approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lhotari lhotari

Labels

cherry-picked/branch-4.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.16 release/4.0.9 release/4.1.3

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

[Bug][Broker] Escaped NoSuchElementException exception throw in EntryCountEstimator causes dispatcher to stop dispatching messages

3 participants

@lhotari @Shawyeok @BewareMyPower