Skip to content

[improve][client]Reduce unnecessary getPartitionedTopicMetadata requests when using retry and DLQ topics. #25172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zjxxzjwang wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[improve][client]Reduce unnecessary getPartitionedTopicMetadata requests when using retry and DLQ topics. #25172

zjxxzjwang wants to merge 5 commits into from
+102 −2

Conversation

@zjxxzjwang
Copy link
Contributor

@zjxxzjwang zjxxzjwang commented Jan 21, 2026 •
edited
Loading

Motivation

Reduce unnecessary getPartitionedTopicMetadata requests when using retry and DLQ topics.

The following scenarios:

  1. When retryLetterTopic is not set but deadLetterTopic is set
  2. When retryLetterTopic is set but deadLetterTopic is not set

These scenarios will trigger the getPartitionedTopicMetadata operation for both the retry topic and DLQ topic, this leads to resource wastage.

Modifications

Perform verification separately. If retryLetterTopic or deadLetterTopic is set, do not proceed to getPartitionedTopicMetadata.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions
Copy link

github-actions bot commented Jan 21, 2026

@zjxxzjwang Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jan 21, 2026
@zjxxzjwang zjxxzjwang changed the title [improve][broker]Reduce unnecessary creation of retry topic and DLQ topic [improve][client]Reduce unnecessary creation of retry topic and DLQ topic Jan 22, 2026
@hanmz hanmz requested review from hanmz and poorbarcode January 22, 2026 03:19
@hanmz hanmz assigned Jason918, wolfstudy and zjxxzjwang and unassigned Jason918 and wolfstudy Jan 22, 2026
@hanmz hanmz requested review from Jason918 and wolfstudy January 22, 2026 03:20
@hanmz
Copy link
Contributor

hanmz commented Jan 22, 2026

Plz add unit tests to cover this logic.

@zjxxzjwang zjxxzjwang changed the title [improve][client]Reduce unnecessary creation of retry topic and DLQ topic [improve][client]Reduce unnecessary getPartitionedTopicMetadata requests when using retry and DLQ topics. Jan 22, 2026
@zjxxzjwang
Copy link
Contributor Author

zjxxzjwang commented Jan 22, 2026

Plz add unit tests to cover this logic.

I have added unit testing

lhotari
lhotari approved these changes Jan 23, 2026
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhotari lhotari lhotari approved these changes

@thetumbled thetumbled thetumbled approved these changes

@poorbarcode poorbarcode Awaiting requested review from poorbarcode

@hanmz hanmz Awaiting requested review from hanmz

@Jason918 Jason918 Awaiting requested review from Jason918

@wolfstudy wolfstudy Awaiting requested review from wolfstudy

Assignees

@zjxxzjwang zjxxzjwang

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zjxxzjwang @hanmz @lhotari @thetumbled @Jason918 @wolfstudy