ORC-2046: Fix macos-14-arm64 CI failure #2455

cxzl25 · 2025-10-28T07:36:35Z

What changes were proposed in this pull request?

Why are the changes needed?

https://github.com/actions/runner-images/issues/12934

Success https://github.com/apache/orc/actions/runs/17684310687/job/50265505914

Runner Image
  Image: macos-14-arm64
  Version: 20250901.1774
  Included Software: https://github.com/actions/runner-images/blob/macos-14-arm64/20250901.1774/images/macos/macos-14-arm64-Readme.md

Failed https://github.com/apache/orc/actions/runs/18735596344/job/53524232003?pr=2452

Runner Image
  Image: macos-14-arm64
  Version: 20251013.0032
  Included Software: https://github.com/actions/runner-images/blob/macos-14-arm64/20251013.0032/images/macos/macos-14-arm64-Readme.md

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

dongjoon-hyun · 2025-10-28T15:03:10Z

Thank you, @cxzl25 . If it's difficult, we may want to upgrade MacOS CI inevitably in branch-1.9 from 14 to 15+.

ORC-1995: Add `MacOS 26` to GitHub Action CI and docs
ORC-1895: Add `MacOS 15` to `macos-cpp-check` GitHub Action job
ORC-1783: Add MacOS 15 to GitHub Action MacOS CI and docs

cxzl25 · 2025-10-28T15:43:33Z

we may want to upgrade MacOS CI inevitably in branch-1.9 from 14 to 15+.

As described in the issue associated with the PR, I estimate that the reason is that the CI of the 1.9 branch failed due to the upgrade of macos image cmake from version 3.x to 4.x.
After upgrading to macos15, the cmake version is also 4.x. After testing, it also failed.

dongjoon-hyun · 2025-10-28T17:32:35Z

Got it. Thank you for investigating.

This reverts commit 52cad7b.

This reverts commit 5f70187.

cxzl25 · 2025-11-07T11:01:25Z

.github/workflows/build_and_test.yml

+    - name: Install CMake
+      if: matrix.os == 'macos-14'
+      run: |
+        # Pin cmake to 3.31.6 due to a backward compatibility issue


Refer to this code to install cmake 3.x version.

https://github.com/actions/runner-images/pull/12791

This reverts commit abfbf54.

dongjoon-hyun · 2026-01-03T13:06:29Z

If this is ready, could you make this Ready status, @cxzl25 ?

dongjoon-hyun · 2026-01-03T13:07:20Z

cc @williamhyun , too.

dongjoon-hyun · 2026-01-03T13:08:38Z

IIUC, the error message looks like the following, right?

CMake Error at /Users/runner/work/orc/orc/build/snappy_ep-prefix/src/snappy_ep-stamp/snappy_ep-configure-RELWITHDEBINFO.cmake:49 (message):
  Command failed: 1

   '/opt/homebrew/bin/cmake' '-DCMAKE_INSTALL_PREFIX=/Users/runner/work/orc/orc/build/c++/libs/thirdparty/snappy_ep-install' '-DBUILD_SHARED_LIBS=OFF' '-DCMAKE_INSTALL_LIBDIR=lib' '-DSNAPPY_BUILD_TESTS=OFF' '-GUnix Makefiles' '-S' '/Users/runner/work/orc/orc/build/snappy_ep-prefix/src/snappy_ep' '-B' '/Users/runner/work/orc/orc/build/snappy_ep-prefix/src/snappy_ep-build'

Make Error at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.

cxzl25 · 2026-01-03T13:27:00Z

the error message looks like the following

Yes, because after the macos image was upgraded, the cmake version was also upgraded, causing CI to fail.

Copilot

Pull request overview

This PR addresses a backward compatibility issue introduced by a GitHub Actions runner image update on macOS-14 that broke the build. The solution pins CMake to version 3.31.6 using Homebrew to maintain compatibility with the project's CMake configuration.

Key Changes

Added a new step to install a pinned version of CMake (3.31.6) on macOS-14 runners
Uses Homebrew tap mechanism to install a specific CMake version from a historical commit

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/build_and_test.yml

dongjoon-hyun · 2026-01-03T13:29:11Z

Could you file an official JIRA issue and use it in the PR title?

dongjoon-hyun · 2026-01-03T13:30:07Z

Since milestone is set, we can remove [1.9] from the PR title, too.

cxzl25 · 2026-01-03T13:32:55Z

Could you file an official JIRA issue and use it in the PR title?

Sure. I've created the JIRA issue and updated the PR title.

dongjoon-hyun

+1, LGTM.

dongjoon-hyun · 2026-01-03T13:34:55Z

When you have some time, could you do the review and the final sign-off as a release manager, @williamhyun ?

williamhyun

+1
Thank you @cxzl25 and @dongjoon-hyun, will be merging this now!

### What changes were proposed in this pull request? ### Why are the changes needed? ``` actions/runner-images#12934 ``` Success https://github.com/apache/orc/actions/runs/17684310687/job/50265505914 ``` Runner Image Image: macos-14-arm64 Version: 20250901.1774 Included Software: https://github.com/actions/runner-images/blob/macos-14-arm64/20250901.1774/images/macos/macos-14-arm64-Readme.md ``` Failed https://github.com/apache/orc/actions/runs/18735596344/job/53524232003?pr=2452 ``` Runner Image Image: macos-14-arm64 Version: 20251013.0032 Included Software: https://github.com/actions/runner-images/blob/macos-14-arm64/20251013.0032/images/macos/macos-14-arm64-Readme.md ``` ### How was this patch tested? ### Was this patch authored or co-authored using generative AI tooling? Closes #2455 from cxzl25/env_cmake. Authored-by: sychen <sychen@ctrip.com> Signed-off-by: William Hyun <william@apache.org>

github-actions bot added the INFRA label Oct 28, 2025

cxzl25 marked this pull request as draft October 28, 2025 13:46

CMAKE_POLICY_VERSION_MINIMUM=3.5

abfbf54

cxzl25 force-pushed the env_cmake branch 4 times, most recently from 9688759 to abfbf54 Compare October 28, 2025 14:28

cxzl25 added 2 commits October 28, 2025 23:35

test macos-15

5f70187

remove env

52cad7b

cxzl25 added 5 commits November 7, 2025 18:27

Revert "remove env"

27120d8

This reverts commit 52cad7b.

Revert "test macos-15"

36fd99a

This reverts commit 5f70187.

cmake

d762ffb

cmake

b0d62b5

cmake

d1d8819

cxzl25 commented Nov 7, 2025

View reviewed changes

Revert "CMAKE_POLICY_VERSION_MINIMUM=3.5"

331a72d

This reverts commit abfbf54.

cxzl25 marked this pull request as ready for review January 3, 2026 13:25

cxzl25 requested a review from Copilot January 3, 2026 13:27

Copilot started reviewing on behalf of cxzl25 January 3, 2026 13:27 View session

Copilot AI reviewed Jan 3, 2026

View reviewed changes

.github/workflows/build_and_test.yml Show resolved Hide resolved

.github/workflows/build_and_test.yml Show resolved Hide resolved

.github/workflows/build_and_test.yml Show resolved Hide resolved

dongjoon-hyun added this to the 1.9.8 milestone Jan 3, 2026

cxzl25 changed the title ~~[1.9] CMAKE_POLICY_VERSION_MINIMUM=3.5~~ ORC-2046: Fix macos-14-arm64 CI failure Jan 3, 2026

dongjoon-hyun approved these changes Jan 3, 2026

View reviewed changes

williamhyun approved these changes Jan 3, 2026

View reviewed changes

williamhyun closed this Jan 3, 2026

ORC-2046: Fix macos-14-arm64 CI failure #2455

ORC-2046: Fix macos-14-arm64 CI failure #2455

Uh oh!

Conversation

cxzl25 commented Oct 28, 2025

What changes were proposed in this pull request?

Why are the changes needed?

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

Uh oh!

dongjoon-hyun commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cxzl25 commented Oct 28, 2025

Uh oh!

dongjoon-hyun commented Oct 28, 2025

Uh oh!

cxzl25 Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

dongjoon-hyun commented Jan 3, 2026

Uh oh!

dongjoon-hyun commented Jan 3, 2026

Uh oh!

dongjoon-hyun commented Jan 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cxzl25 commented Jan 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dongjoon-hyun commented Jan 3, 2026

Uh oh!

dongjoon-hyun commented Jan 3, 2026

Uh oh!

cxzl25 commented Jan 3, 2026

Uh oh!

dongjoon-hyun left a comment

Choose a reason for hiding this comment

Uh oh!

dongjoon-hyun commented Jan 3, 2026

Uh oh!

williamhyun left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dongjoon-hyun commented Oct 28, 2025 •

edited

Loading

dongjoon-hyun commented Jan 3, 2026 •

edited

Loading

williamhyun left a comment •

edited

Loading