drivers/usbdev: fix rndis net link status can't update timely issue #18125
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: Drivers
jerpelea
requested changes
Jan 23, 2026
Contributor
jerpelea
left a comment
jerpelea
left a comment
There was a problem hiding this comment.
please move to a separate PR since the PR is open on another topci
jerpelea
changed the title
Contributor
|
Hi @masc2008 thank you contribution! Please read the CONTRIBUTING.md to guide you. |
… +0800 drivers/usbdev/rndis: after client send notication, host can't read msg timely rndis use intr ep to notify host to read RNDIS message from client, it should read all the messages cached. Need notify host to read again if there is msg left. Signed-off-by: Jerry Ma <shichunma@bestechnic.com>
Contributor
Author
xiaoxiang781216
approved these changes
Jan 24, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
The link status of RNDIS net device needs to keep synchronous with the link status of the network on the system which has internet communication function. This link status event can be sent to host since RNDIS has interrupt endpoint to notify host that "I have something to notify you, please read from me". Then host will use control endpoint to do msg query from nuttx side. Everything will go well if one notification, then read one msg.
however, situation will go complicated: if more than two intr ep events (that means more than two msg need to be reported to host) happen in quite short time and host just read once, then the msg in nuttx will become cached more and more.
What RNDIS client side do:
To this issue, I prefer 2 to fix it. It has high efficiency. Especially considering that the host read msg length is "0x1000" when it query from client.
Impact
give as much as possible for the response msg, this imply the RNDIS spec which mentioned in 2.2.14.
Testing
Tested and can see multi msgs may return in one USB control transfer.