Skip to content

Conversation

@CTTY
Copy link
Collaborator

@CTTY CTTY commented Jan 2, 2026

Which issue does this PR close?

What changes are included in this PR?

  • Write content to V3 manifest so the field is preserved correctly for delete entry

Are these changes tested?

Yes

Comment on lines +440 to +442
if self.metadata.format_version == FormatVersion::V2
|| self.metadata.format_version == FormatVersion::V3
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth using a match on self.metadata.format_version here similar to the pattern used in avro_schema above, so the compiler can catch any unhandled versions
in the future.

        match self.metadata.format_version {
            FormatVersion::V1 => {}
            FormatVersion::V2 | FormatVersion::V3 => {
                avro_writer
                    .add_user_metadata("content".to_string(), self.metadata.content.to_string())?;
            }
        }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

V3 manifest writer does not write content metadata field

2 participants