feat: Add DeleteFileIndex to improve position delete lookup #2918
+422
−100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2255.
Rationale for this change
This PR is a piece of the existing DFI PR in #2255. However, this rips out the existing delete->data matching behavior for deletes and indexes them for efficient lookup.
The previous implementation:
_InclusiveMetricsEvaluatorinstance for each data fileNow we extend this workflow with a
DeleteFileIndexthat:This aligns with the Java implementation of the DeleteFileIndex, following the python infra.
Are these changes tested?
New tests added and existing tests continue to pass
Are there any user-facing changes?
No