HBASE-29775 Allow inspecting log levels in Master UI in read-only mode #7540

jinhyukify · 2025-12-12T15:25:18Z

Jira https://issues.apache.org/jira/browse/HBASE-29775

Please refer to this comment for testing details.

NihalJain · 2025-12-15T05:18:17Z

Thank you for the fix @jinhyukify. Changes looks good to me, do you mind extending this class 'TestLogLevel' to cover missing readonly scenario, if any?

Copilot

Pull request overview

This PR enables read-only inspection of log levels in the Master UI when hbase.master.ui.readonly is configured. Previously, the readonly check blocked all access to the LogLevel servlet; now it only blocks modification operations while allowing users to view current log levels.

Moves the readonly configuration check from blocking all requests to only blocking modification requests (when the level parameter is present)
Relocates Configuration object retrieval to after parameter extraction to support conditional readonly enforcement

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-15T05:27:44Z

hbase-http/src/main/java/org/apache/hadoop/hbase/http/log/LogLevel.java

+          if (conf.getBoolean("hbase.master.ui.readonly", false)) {
+            sendError(response, HttpServletResponse.SC_FORBIDDEN,
+              "Modification of HBase via the UI is disallowed in configuration.");
+            return;
+          }


The readonly check at line 333 occurs after the response body has already been written (header.jsp included at line 310, FORMS written at line 316, and potentially more output at lines 326-330). Calling sendError() at this point will not work correctly because the HTTP response has already been committed. The status code cannot be changed after the response body has started being written, which will result in either an IllegalStateException or a malformed HTTP response.

To fix this issue, the readonly check should be moved earlier in the method, before any output is written to the response. One approach would be to check if level is not null and readonly mode is enabled right after retrieving the parameters (around line 320), but before writing any output beyond that point. Alternatively, the check could be conditional on whether we're about to write the forms or process the request.

…output

jinhyukify · 2025-12-27T05:19:20Z

hbase-http/src/main/java/org/apache/hadoop/hbase/http/log/LogLevel.java

+      System.out.println(fetchGetLevelResponse());
+    }
+
+    String fetchGetLevelResponse() throws Exception {
+      return fetchResponse(protocol + "://" + hostName + "/logLevel?log=" + className);


The previous implementation printed results only to standard output, making it hard to write tests. I refactored the code slightly to separate the logic.

jinhyukify · 2025-12-27T05:21:20Z

hbase-http/src/test/java/org/apache/hadoop/hbase/http/log/TestLogLevel.java

+        testSetLogLevel(Protocol.C_HTTP_S_HTTP, true, logName, "INFO");
+        fail("Setting log level should be disallowed in readonly mode.");


This verifies log level updates in read-only mode.

jinhyukify · 2025-12-27T05:21:29Z

hbase-http/src/test/java/org/apache/hadoop/hbase/http/log/TestLogLevel.java

+  public void testGetLogLevelAllowedInReadonlyMode() throws Exception {
+    withMasterUIReadonly(() -> {
+      Log4jUtils.setLogLevel(logName, "DEBUG");
+      testGetLogLevel(Protocol.C_HTTP_S_HTTP, true, logName, "DEBUG");


This verifies log level reads in read-only mode.

jinhyukify · 2025-12-27T05:22:36Z

@NihalJain Thank you for checking this! The current code structure made it difficult to write tests, so I did a small refactoring and added test cases.

Apache9 · 2025-12-27T12:25:02Z

hbase-http/src/main/java/org/apache/hadoop/hbase/http/log/LogLevel.java

+          .collect(Collectors.joining("\n"));
      } catch (IOException ioe) {
-        System.err.println("" + ioe);
+        return "" + ioe;


In the old logic, this will go to stderr, but now it will go to stdout? I'm not very familiar with this area, so I'm not sure whether this is a problem...

Thanks for the review. Good catch.

One thing I wanted to mention is that the previous behavior already felt a bit inconsistent.
We were catching only IOException here and printing it to standard error, while other exceptions were simply propagated..

That special handling for IOException feels slightly odd to me. Since this is a CLI command, I am considering not catching IOException here at all and letting it propagate, the same way other exceptions do.

I understand that this could technically be a behavior change for users who rely on standard error, but printing only this specific exception to stderr also seems inconsistent from a CLI semantics point of view.

I would like to hear your thoughts on whether there is a strong reason to keep this special case.

Tried blaming the code and checking the history, seems we just copied it from hadoop, where it was like this in the first place...

26096f3#diff-b4ce56ed340edb8a81d682407d525acea495757156a146724ae59b485ea13a13

OK, in hadoop they have changed the behavior long ago, in this commit...

apache/hadoop@34cc21f#diff-e2f617505927c3cbfc70219b4fde7332e84230d692f8102c0c715fa7a9fd1f82

So let's also throw the IOException out.

Ah, I see this code originally came from Hadoop. Thanks for checking and confirming.
Fixed in 6b03852

Apache-HBase · 2025-12-28T18:40:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	3m 7s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	2m 55s		master passed
+1 💚	compile	0m 17s		master passed
+1 💚	javadoc	0m 12s		master passed
+1 💚	shadedjars	5m 59s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 57s		the patch passed
+1 💚	compile	0m 17s		the patch passed
+1 💚	javac	0m 17s		the patch passed
+1 💚	javadoc	0m 13s		the patch passed
+1 💚	shadedjars	6m 0s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 46s		hbase-http in the patch passed.
		23m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7540/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7540
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 2eb3a098e7ce 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6b03852`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7540/3/testReport/
Max. process+thread count	402 (vs. ulimit of 30000)
modules	C: hbase-http U: hbase-http
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7540/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-12-28T18:47:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	3m 50s		master passed
+1 💚	compile	0m 27s		master passed
+1 💚	checkstyle	0m 13s		master passed
+1 💚	spotbugs	0m 30s		master passed
+1 💚	spotless	0m 48s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 5s		the patch passed
+1 💚	compile	0m 27s		the patch passed
+1 💚	javac	0m 27s		hbase-http generated 0 new + 36 unchanged - 1 fixed = 36 total (was 37)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 10s		the patch passed
+1 💚	spotbugs	0m 32s		the patch passed
+1 💚	hadoopcheck	12m 8s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 45s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 10s		The patch does not generate ASF License warnings.
		31m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7540/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7540
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 882fb922e3b4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6b03852`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-http U: hbase-http
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7540/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

HBASE-29775 Allow inspecting log levels in Master UI in read-only mode

03444e5

This comment has been minimized.

Sign in to view

NihalJain requested review from NihalJain and Copilot December 15, 2025 05:18

Copilot started reviewing on behalf of NihalJain December 15, 2025 05:19 View session

Copilot AI reviewed Dec 15, 2025

View reviewed changes

jinhyukify added 2 commits December 27, 2025 03:22

HBASE-29775 Refactor LogLevel CLI to separate response fetching from …

aad663f

…output

HBASE-29775 Add tests for LogLevel readonly master UI mode

91167a0

This comment has been minimized.

Sign in to view

jinhyukify commented Dec 27, 2025

View reviewed changes

Apache9 reviewed Dec 27, 2025

View reviewed changes

HBASE-29775 Propagate IOException instead of catching it

6b03852

Apache9 approved these changes Dec 29, 2025

View reviewed changes

		testSetLogLevel(Protocol.C_HTTP_S_HTTP, true, logName, "INFO");
		fail("Setting log level should be disallowed in readonly mode.");

HBASE-29775 Allow inspecting log levels in Master UI in read-only mode #7540

Are you sure you want to change the base?

HBASE-29775 Allow inspecting log levels in Master UI in read-only mode #7540

Conversation

jinhyukify commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

NihalJain commented Dec 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

jinhyukify Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

jinhyukify Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

jinhyukify Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

jinhyukify commented Dec 27, 2025

Uh oh!

Apache9 Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

jinhyukify Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Apache9 Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

Apache9 Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

jinhyukify Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Dec 28, 2025

Uh oh!

Apache-HBase commented Dec 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jinhyukify commented Dec 12, 2025 •

edited

Loading

jinhyukify Dec 27, 2025 •

edited

Loading