Add BucketingFunctionTest, this allows rust client side to also run the same test and ensures consistency. #2274
+121
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he same test and ensures consistency.
…he same test and ensures consistency.
Contributor
Author
|
@luoyuxia Would appreciate review here as this implements the same test in rust client to ensure hashing consistency between java side and rust side. |
luoyuxia
reviewed
Jan 4, 2026
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@leekeiabstraction Thanks for the pr. Left minor comment.
fluss-common/src/test/java/org/apache/fluss/bucketing/BucketingFunctionTest.java
Outdated
Show resolved
Hide resolved
fluss-common/src/test/java/org/apache/fluss/bucketing/BucketingFunctionTest.java
Outdated
Show resolved
Hide resolved
fluss-common/src/test/java/org/apache/fluss/bucketing/BucketingFunctionTest.java
Outdated
Show resolved
Hide resolved
fluss-common/src/test/java/org/apache/fluss/bucketing/BucketingFunctionTest.java
Outdated
Show resolved
Hide resolved
fluss-common/src/test/java/org/apache/fluss/bucketing/BucketingFunctionTest.java
Outdated
Show resolved
Hide resolved
fluss-common/src/test/java/org/apache/fluss/bucketing/BucketingFunctionTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: yuxia Luo <luoyuxia@alumni.sjtu.edu.cn>
Co-authored-by: yuxia Luo <luoyuxia@alumni.sjtu.edu.cn>
Co-authored-by: yuxia Luo <luoyuxia@alumni.sjtu.edu.cn>
Co-authored-by: yuxia Luo <luoyuxia@alumni.sjtu.edu.cn>
Co-authored-by: yuxia Luo <luoyuxia@alumni.sjtu.edu.cn>
Co-authored-by: yuxia Luo <luoyuxia@alumni.sjtu.edu.cn>
Contributor
Author
|
@luoyuxia thank you for the comments. Accepted the suggested changes. |
Contributor
Author
|
The CI failure should now be fixed |
luoyuxia
approved these changes
Jan 9, 2026
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@leekeiabstraction Thanks LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
See related issue apache/fluss-rust#117
Brief change log
Add BucketingFunctionTest, this allows rust client side to also run the same test and ensures consistency.
Tests
Added tests for default, Paimon, Lance and Datalake BucketingFunctions.