-
Notifications
You must be signed in to change notification settings - Fork 2.2k
FINERACT-2206: Correct typo 'allowPartialPeriodInterestCalcualtion' in code and REST API #5279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
FINERACT-2206: Correct typo 'allowPartialPeriodInterestCalcualtion' in code and REST API #5279
Conversation
| protected static final GenericContainer POSTGRES_CONTAINER = new GenericContainer("postgres:16").withNetwork(network) | ||
| .withNetworkAliases("postgres").withExposedPorts(5432) | ||
| .withEnv(Map.of("POSTGRES_DB", "fineract-test", "POSTGRES_USER", "root", "POSTGRES_PASSWORD", "mifos")); | ||
| protected static final GenericContainer<?> POSTGRES_CONTAINER = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why needed to change on CommandBaseTest.java is it related to typo?
IOhacker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unrelated changes, squash and commit
|
Hi Monica,
If you think this is another issue the open a new ticket and describe on
that ticket which are the conditions that raise the error.
I have to remark that it is not a Apache Fineract issue because the system
is working with the typo.
You should investigate the root cause of the inestability faced in your
development environment.
El El jue, 1 de ene de 2026 a la(s) 7:22 a.m., Monica <
***@***.***> escribió:
… ***@***.**** commented on this pull request.
------------------------------
In
fineract-command/src/test/java/org/apache/fineract/command/CommandBaseTest.java
<#5279 (comment)>:
> @@ -40,9 +40,17 @@ abstract class CommandBaseTest {
protected static Network network = Network.newNetwork();
@container
- protected static final GenericContainer POSTGRES_CONTAINER = new GenericContainer("postgres:16").withNetwork(network)
- .withNetworkAliases("postgres").withExposedPorts(5432)
- .withEnv(Map.of("POSTGRES_DB", "fineract-test", "POSTGRES_USER", "root", "POSTGRES_PASSWORD", "mifos"));
+ protected static final GenericContainer<?> POSTGRES_CONTAINER =
The change in CommandBaseTest.java was committed because the test suite
was failing without explicitly setting the timezone. While working on the
typo fix, the tests exposed an existing instability caused by timezone
differences between environments.To ensure the build passes reliably and
tests remain deterministic across systems, the timezone configuration was
added to the test setup. This is a test infrastructure fix, not a
functional or API change, found it necessary to complete and validate the
typo-related changes.
—
Reply to this email directly, view it on GitHub
<#5279 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALD2ZAQFY2UPS3Y3CO2IJAT4EUNQXAVCNFSM6AAAAACQOHKF3CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMMRRHA2TSNRSGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Hi IOhacker, |
785e03e to
f94427b
Compare
|
@Monica-CodingWorld stay stick to the change, as I have writen by email the change is in 35 files and there are 142 ocurrences. This is the fix that is describe in the Jira ticket and that has been discussed by email. There are no more changes required to be done in that ticket. By the way you can remove the TZ/Hibernate in the PR description. Thank you for your effort! Go ahead! |
|
@Monica-CodingWorld "One line of code at a time" you should focus your initial contributtion efforts on writing small, functional pieces of code and then gradually you will see progress in all your skills |
Fixed misspelled 'allowPartialPeriodInterestCalcualtion' to 'allowPartialPeriodInterestCalculation' in REST API and code. 35 files updated as specified in JIRA.
f94427b to
f5d766b
Compare
@IOhacker PR description updated as requested:
Ready for final review. |
@IOhacker Thank you Victor actually learn a lot about open source from this. The PR is now focused solely on the 35-file, 142-occurrence typo fix described in the JIRA ticket. |
|
LGTM, wait for the results of the GA checks. |
|
@Monica-CodingWorld there are errors in the Github Actions (GA) please make sure that your testing in the GA are passing. You can debug it. |
|
|
@Monica-CodingWorld Please apply this patch: |
Fixed startDate from dynamic current year to hardcoded 2025 in testPostInterestNotZero() to maintain consistent 2025 timeline. Resolves HTTP 400 error caused by date mismatches.
Description
This PR fixes a typo in the code and REST API:
Replaced all occurrences of the misspelled 'allowPartialPeriodInterestCalcualtion' with the correct 'allowPartialPeriodInterestCalculation'
Changes applied across 35 files including LoanProductConstants.java, API resources, and test classes
Ensures consistency between code, constants, and REST API fields
Changes: 35 files updated with typo fixes
Scope: Only the typo fix as specified in the JIRA ticket
Build Status: ✅ Compilation passes successfully
JIRA Issue: https://issues.apache.org/jira/browse/FINERACT-2206
Checklist
Note
The failing test are unrelated to this PR as this PR only fixes a typo in 35 files with no logic changes