Skip to content

Conversation

@deardeng
Copy link
Contributor

What problem does this PR solve?

Fix

2025-12-30 16:10:42,774 ERROR (replayer|123) [EditLog.loadJournal():1445] replay Operation Type 210, log id: 1910
java.lang.NullPointerException
        at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:906)
        at org.apache.doris.catalog.OlapTable.checkPartition(OlapTable.java:2835)
        at org.apache.doris.catalog.OlapTable.replaceTempPartitions(OlapTable.java:2799)
        at org.apache.doris.catalog.Env.replayReplaceTempPartition(Env.java:6750)
        at org.apache.doris.persist.EditLog.loadJournal(EditLog.java:986)
        at org.apache.doris.catalog.Env.replayJournal(Env.java:3100)
        at org.apache.doris.catalog.Env$4.runOneCycle(Env.java:2862)
        at org.apache.doris.common.util.Daemon.run(Daemon.java:119)
2025-12-30 16:10:42,775 INFO (Thread-0|32) [DorisFE.lambda$start$0():159] Received shutdown signal, starting graceful shutdown...
2025-12-30 16:10:42,776 INFO (Thread-0|32) [DorisFE.gracefulShutdown():639] graceful shutdown finished

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@deardeng
Copy link
Contributor Author

run buildall

@deardeng deardeng force-pushed the fix-race-create-insertoverwrite branch from af9cd0a to 65716c4 Compare December 30, 2025 09:30
@deardeng deardeng force-pushed the fix-race-create-insertoverwrite branch from 65716c4 to 4e4efb1 Compare December 30, 2025 09:37
@doris-robot
Copy link

TPC-H: Total hot run time: 35222 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0e4b3d58841b9bf23a31c7fda3a23047d930c555, data reload: false

------ Round 1 ----------------------------------
q1	16471	4225	4029	4029
q2	2006	348	231	231
q3	9905	1269	731	731
q4	9986	840	313	313
q5	7705	2159	1867	1867
q6	186	169	134	134
q7	939	810	665	665
q8	9276	1397	1136	1136
q9	6736	5117	5163	5117
q10	6787	1804	1403	1403
q11	510	297	294	294
q12	685	770	613	613
q13	17796	3809	3116	3116
q14	303	305	281	281
q15	568	514	513	513
q16	736	701	640	640
q17	700	760	629	629
q18	7588	7365	8356	7365
q19	1134	974	671	671
q20	446	383	251	251
q21	4562	4378	4180	4180
q22	1150	1128	1043	1043
Total cold run time: 106175 ms
Total hot run time: 35222 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4262	4241	4322	4241
q2	301	377	341	341
q3	2239	2861	2349	2349
q4	1466	1868	1430	1430
q5	4626	4300	4233	4233
q6	219	169	129	129
q7	1992	1905	1861	1861
q8	2561	2299	2338	2299
q9	7180	7171	7142	7142
q10	2629	2724	2300	2300
q11	533	467	450	450
q12	749	741	607	607
q13	3656	4054	3088	3088
q14	276	276	261	261
q15	525	485	495	485
q16	619	641	592	592
q17	1104	1236	1336	1236
q18	7488	7113	7340	7113
q19	889	848	899	848
q20	1894	1955	1779	1779
q21	4517	4297	4142	4142
q22	1104	1014	1008	1008
Total cold run time: 50829 ms
Total hot run time: 47934 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173947 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0e4b3d58841b9bf23a31c7fda3a23047d930c555, data reload: false

query5	4697	584	430	430
query6	329	215	214	214
query7	4207	463	284	284
query8	329	238	241	238
query9	8759	2596	2644	2596
query10	547	353	309	309
query11	15144	14936	14734	14734
query12	167	118	110	110
query13	1281	483	388	388
query14	6192	2971	2719	2719
query14_1	2663	2650	2553	2553
query15	203	190	174	174
query16	974	472	457	457
query17	1055	669	560	560
query18	2489	424	336	336
query19	214	214	188	188
query20	120	121	119	119
query21	214	139	122	122
query22	3801	3981	3943	3943
query23	15929	15449	15325	15325
query23_1	15277	15300	15419	15300
query24	7113	1568	1216	1216
query24_1	1220	1195	1219	1195
query25	565	433	395	395
query26	1242	271	160	160
query27	2761	456	291	291
query28	4442	2178	2164	2164
query29	778	511	416	416
query30	305	243	212	212
query31	737	623	559	559
query32	76	75	66	66
query33	527	333	275	275
query34	873	903	528	528
query35	737	774	692	692
query36	861	891	834	834
query37	135	91	80	80
query38	2761	2708	2668	2668
query39	764	749	733	733
query39_1	711	723	713	713
query40	221	130	116	116
query41	65	63	64	63
query42	108	100	100	100
query43	464	457	410	410
query44	1341	766	758	758
query45	188	178	173	173
query46	864	951	614	614
query47	1333	1447	1379	1379
query48	322	322	241	241
query49	621	422	337	337
query50	642	267	215	215
query51	3737	3752	3729	3729
query52	102	107	92	92
query53	295	326	275	275
query54	275	249	245	245
query55	79	78	67	67
query56	280	290	293	290
query57	1036	1013	931	931
query58	259	252	266	252
query59	1982	2202	2048	2048
query60	309	313	309	309
query61	163	158	156	156
query62	392	356	304	304
query63	300	272	268	268
query64	4959	1421	1120	1120
query65	3766	3749	3715	3715
query66	1434	433	330	330
query67	15013	15014	15213	15014
query68	3013	1044	769	769
query69	479	352	310	310
query70	972	890	885	885
query71	328	305	284	284
query72	6660	5059	4961	4961
query73	548	640	317	317
query74	8771	8744	8579	8579
query75	2821	2878	2484	2484
query76	3459	1059	661	661
query77	516	367	280	280
query78	9771	9847	9104	9104
query79	1585	903	603	603
query80	856	571	479	479
query81	529	267	235	235
query82	385	142	111	111
query83	251	262	236	236
query84	261	111	108	108
query85	921	515	441	441
query86	405	303	320	303
query87	2790	2885	2763	2763
query88	3280	2295	2287	2287
query89	372	354	331	331
query90	2093	151	140	140
query91	172	167	143	143
query92	81	67	65	65
query93	1678	920	564	564
query94	644	324	286	286
query95	575	383	306	306
query96	591	478	213	213
query97	2323	2402	2260	2260
query98	231	210	196	196
query99	602	587	504	504
Total cold run time: 248364 ms
Total hot run time: 173947 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.64 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0e4b3d58841b9bf23a31c7fda3a23047d930c555, data reload: false

query1	0.06	0.04	0.05
query2	0.09	0.05	0.05
query3	0.27	0.08	0.08
query4	1.61	0.11	0.11
query5	0.26	0.27	0.26
query6	1.15	0.67	0.65
query7	0.03	0.02	0.03
query8	0.05	0.04	0.04
query9	0.56	0.50	0.51
query10	0.54	0.55	0.56
query11	0.15	0.11	0.11
query12	0.16	0.13	0.13
query13	0.61	0.61	0.60
query14	0.99	0.96	0.98
query15	0.81	0.80	0.79
query16	0.40	0.39	0.39
query17	1.04	1.02	1.06
query18	0.23	0.22	0.21
query19	1.93	1.76	1.82
query20	0.02	0.02	0.01
query21	15.43	0.30	0.13
query22	4.74	0.04	0.04
query23	15.98	0.30	0.11
query24	0.95	1.06	0.65
query25	0.11	0.12	0.06
query26	0.14	0.14	0.13
query27	0.09	0.06	0.05
query28	5.49	1.05	0.89
query29	12.59	4.01	3.21
query30	0.27	0.14	0.11
query31	2.83	0.61	0.38
query32	3.23	0.55	0.46
query33	3.03	2.96	3.00
query34	16.71	5.12	4.49
query35	4.44	4.79	5.09
query36	0.70	0.55	0.55
query37	0.10	0.08	0.06
query38	0.07	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.16	0.14
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.04
Total cold run time: 98.23 s
Total hot run time: 27.64 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 32.65% (16/49) 🎉
Increment coverage report
Complete coverage report

Copy link
Contributor

@yujun777 yujun777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@deardeng deardeng force-pushed the fix-race-create-insertoverwrite branch from 5d3e332 to 14d4d5e Compare December 31, 2025 07:51
Copy link
Contributor

@yujun777 yujun777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deardeng
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34318 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 14d4d5ef23ed8ab100c5c2c097183a2af56bdfcf, data reload: false

------ Round 1 ----------------------------------
q1	16530	4174	4055	4055
q2	2012	355	240	240
q3	9756	1575	725	725
q4	9747	839	318	318
q5	7300	2092	1927	1927
q6	188	171	135	135
q7	940	786	665	665
q8	8973	1387	1184	1184
q9	6801	5188	5140	5140
q10	6763	1823	1409	1409
q11	520	304	311	304
q12	693	746	582	582
q13	17192	3794	3080	3080
q14	299	293	272	272
q15	566	512	505	505
q16	710	690	643	643
q17	698	700	679	679
q18	7425	7388	7218	7218
q19	1104	974	601	601
q20	417	367	241	241
q21	4351	3976	3411	3411
q22	1048	1031	984	984
Total cold run time: 104033 ms
Total hot run time: 34318 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4089	4047	4051	4047
q2	319	405	319	319
q3	2079	2649	2261	2261
q4	1341	1766	1300	1300
q5	4056	3997	4336	3997
q6	236	192	153	153
q7	2147	2053	1832	1832
q8	2573	2403	2389	2389
q9	7235	7258	7156	7156
q10	2492	2825	2351	2351
q11	578	499	471	471
q12	687	758	627	627
q13	3582	4035	3263	3263
q14	272	304	301	301
q15	550	512	513	512
q16	668	685	668	668
q17	1171	1351	1386	1351
q18	8168	7955	7883	7883
q19	923	895	934	895
q20	1975	2054	1907	1907
q21	4993	4513	4357	4357
q22	1120	1026	989	989
Total cold run time: 51254 ms
Total hot run time: 49029 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 175492 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 14d4d5ef23ed8ab100c5c2c097183a2af56bdfcf, data reload: false

query5	4363	565	461	461
query6	332	220	206	206
query7	4215	475	269	269
query8	342	259	233	233
query9	8739	2583	2609	2583
query10	501	362	310	310
query11	15240	15122	14840	14840
query12	163	112	117	112
query13	1271	487	400	400
query14	5915	2955	2742	2742
query14_1	2634	2607	2640	2607
query15	210	200	175	175
query16	971	482	466	466
query17	1116	786	598	598
query18	2441	443	347	347
query19	236	228	203	203
query20	125	119	116	116
query21	221	141	121	121
query22	4102	4120	4109	4109
query23	16063	15638	15445	15445
query23_1	15533	15448	15504	15448
query24	7116	1615	1215	1215
query24_1	1221	1215	1222	1215
query25	564	495	430	430
query26	1257	272	162	162
query27	2749	466	307	307
query28	4376	2203	2168	2168
query29	823	556	472	472
query30	314	241	212	212
query31	807	639	564	564
query32	83	79	68	68
query33	555	341	324	324
query34	881	879	548	548
query35	750	787	702	702
query36	891	915	859	859
query37	128	95	80	80
query38	2640	2722	2670	2670
query39	762	748	748	748
query39_1	697	706	709	706
query40	214	130	114	114
query41	68	63	67	63
query42	106	104	103	103
query43	474	453	419	419
query44	1327	736	738	736
query45	188	185	175	175
query46	865	965	613	613
query47	1352	1460	1385	1385
query48	321	323	252	252
query49	612	410	330	330
query50	639	269	205	205
query51	3780	3775	3753	3753
query52	102	109	94	94
query53	293	331	277	277
query54	282	252	261	252
query55	77	74	70	70
query56	285	289	318	289
query57	956	1005	899	899
query58	262	248	257	248
query59	2164	2072	2000	2000
query60	315	314	296	296
query61	164	159	157	157
query62	400	332	327	327
query63	301	265	269	265
query64	4865	1349	981	981
query65	3841	3720	3731	3720
query66	1439	426	312	312
query67	15137	15424	15406	15406
query68	7486	993	721	721
query69	491	375	303	303
query70	1026	938	915	915
query71	375	301	273	273
query72	6233	4693	4743	4693
query73	713	585	310	310
query74	8800	8768	8614	8614
query75	2905	2909	2544	2544
query76	3964	1061	661	661
query77	526	375	284	284
query78	9807	9894	9152	9152
query79	1330	918	624	624
query80	644	588	479	479
query81	494	264	238	238
query82	232	151	109	109
query83	270	249	244	244
query84	259	120	110	110
query85	916	499	478	478
query86	349	325	318	318
query87	2959	2852	2752	2752
query88	3164	2297	2263	2263
query89	380	362	341	341
query90	2012	153	153	153
query91	169	168	141	141
query92	71	70	64	64
query93	1016	900	566	566
query94	564	321	302	302
query95	565	331	301	301
query96	588	453	204	204
query97	2345	2358	2329	2329
query98	229	222	195	195
query99	617	605	500	500
Total cold run time: 252491 ms
Total hot run time: 175492 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.38 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 14d4d5ef23ed8ab100c5c2c097183a2af56bdfcf, data reload: false

query1	0.06	0.04	0.04
query2	0.11	0.05	0.05
query3	0.26	0.09	0.08
query4	1.61	0.12	0.11
query5	0.26	0.27	0.29
query6	1.15	0.66	0.66
query7	0.03	0.03	0.02
query8	0.05	0.04	0.05
query9	0.57	0.50	0.51
query10	0.56	0.56	0.54
query11	0.15	0.11	0.11
query12	0.16	0.12	0.12
query13	0.63	0.61	0.59
query14	0.99	1.00	0.97
query15	0.80	0.80	0.80
query16	0.40	0.39	0.38
query17	0.98	1.08	1.06
query18	0.24	0.22	0.22
query19	1.98	1.88	1.84
query20	0.02	0.01	0.01
query21	15.44	0.29	0.14
query22	4.59	0.05	0.04
query23	15.93	0.29	0.11
query24	1.16	0.65	0.61
query25	0.08	0.06	0.11
query26	0.15	0.13	0.14
query27	0.08	0.06	0.06
query28	4.36	1.06	0.88
query29	12.65	3.95	3.14
query30	0.28	0.14	0.12
query31	2.81	0.62	0.38
query32	3.23	0.55	0.47
query33	3.00	3.03	3.04
query34	16.58	5.07	4.47
query35	4.51	4.51	4.47
query36	0.65	0.49	0.49
query37	0.11	0.07	0.07
query38	0.08	0.05	0.04
query39	0.05	0.03	0.04
query40	0.18	0.16	0.14
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.05	0.03	0.04
Total cold run time: 97.1 s
Total hot run time: 27.38 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 28.57% (16/56) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 60.71% (34/56) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants